From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5376637B2 for ; Tue, 20 Sep 2016 23:37:45 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP; 20 Sep 2016 14:37:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,370,1470726000"; d="scan'208";a="11462813" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga005.fm.intel.com with ESMTP; 20 Sep 2016 14:37:37 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by IRSMSX109.ger.corp.intel.com ([169.254.13.6]) with mapi id 14.03.0248.002; Tue, 20 Sep 2016 22:37:36 +0100 From: "De Lara Guarch, Pablo" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "Trahe, Fiona" , "Jain, Deepak K" , "Griffin, John" Thread-Topic: [PATCH 1/3] crypto/aesni_gcm: move pre-counter block to GCM driver Thread-Index: AQHR/si7c9saNZiF+UeS7ufp48/ilqCDDBxA Date: Tue, 20 Sep 2016 21:37:35 +0000 Message-ID: References: <1472126563-31268-1-git-send-email-arkadiuszx.kusztal@intel.com> <1472126563-31268-2-git-send-email-arkadiuszx.kusztal@intel.com> In-Reply-To: <1472126563-31268-2-git-send-email-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWEyMjE4NTYtMTc5Ny00NjhlLWFjOGEtYzI4Y2EyOTIxYjA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IitcL1wveXc4VktBZEU0THIzYXRiamtQbnViRWRmbW5najhnbXlZTTFWTXBzWT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] crypto/aesni_gcm: move pre-counter block to GCM driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 21:37:45 -0000 Hi Arek, > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Thursday, August 25, 2016 5:03 AM > To: dev@dpdk.org > Cc: Trahe, Fiona; Jain, Deepak K; De Lara Guarch, Pablo; Griffin, John; > Kusztal, ArkadiuszX > Subject: [PATCH 1/3] crypto/aesni_gcm: move pre-counter block to GCM > driver >=20 > This patch moves computing of pre-counter block into the AESNI-GCM > driver so it can be moved from test files. >=20 > Signed-off-by: Arek Kusztal > --- > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > index dc0b033..d8b6287 100644 > --- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > +++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > @@ -230,11 +230,16 @@ process_gcm_crypto_op(struct aesni_gcm_qp > *qp, struct rte_crypto_sym_op *op, > op->cipher.data.offset); >=20 > /* sanity checks */ > - if (op->cipher.iv.length !=3D 16 && op->cipher.iv.length !=3D 0) { > + if (op->cipher.iv.length !=3D 16 && op->cipher.iv.length !=3D 12 && > + op->cipher.iv.length !=3D 0) { > GCM_LOG_ERR("iv"); > return -1; > } >=20 > + if (op->cipher.iv.length =3D=3D 12) { > + op->cipher.iv.data[15] =3D 1; > + } Is this correct? In the second patch, you are removing code that set this b= yte when IV length was 16, so I would expect this to be the same. Also, if length is 12, then data[15]= looks like overflow. Probably a comment would be useful here. > + > if (op->auth.aad.length !=3D 12 && op->auth.aad.length !=3D 8 && > op->auth.aad.length !=3D 0) { > GCM_LOG_ERR("iv"); > -- > 2.1.0