From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id A4FDB5680
 for <dev@dpdk.org>; Wed, 21 Sep 2016 23:30:38 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP; 21 Sep 2016 14:30:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,375,1470726000"; d="scan'208";a="882438214"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by orsmga003.jf.intel.com with ESMTP; 21 Sep 2016 14:30:37 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.140]) with mapi id 14.03.0248.002;
 Wed, 21 Sep 2016 22:30:36 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Masoud Hasanifard
 <masoudhasanifard@gmail.com>
Thread-Topic: [dpdk-dev] [PATCH] hash: Correctly set the compare function.
Thread-Index: AQHSEMgCQVp2syKntkWsTWZdEj2bF6CBJh1AgANGAoCAABEEQA==
Date: Wed, 21 Sep 2016 21:30:35 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C9FBB23@IRSMSX108.ger.corp.intel.com>
References: <1474105404-27654-1-git-send-email-masoudhasanifard@gmail.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C9F8E0E@IRSMSX108.ger.corp.intel.com>
 <7057001.BY3tcUaArR@xps13>
In-Reply-To: <7057001.BY3tcUaArR@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzk3YTZkZTctNTQ4MS00ZTNmLTkxOGMtMWFiYjQxMWZhNGNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im5BVGpFQlR3ZnFUVmJpRXdVd3pMODlhZEJsWjNHZ1I3Nm9QeFVwU2FkbGc9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Sep 2016 21:30:39 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, September 21, 2016 2:29 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Masoud Hasanifard
> Subject: Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function.
>=20
> 2016-09-19 18:36, De Lara Guarch, Pablo:
> > Commit titles start with lowercase ("correctly") and without a dot at t=
he
> end.
> [...]
> > I think this is a fix, so probably it should contain the following "Fix=
es" line in
> the commit message:
> > Fixes: 95da2f8e9c61 ("hash: customize compare function")
> [...]
> > Good catch! Two comments inline.
> > Could you send a v2 with those two things added?
>=20
> I can do these trivial changes when applying.
> Pablo, do you ack?

I do!