From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
"Griffin, John" <john.griffin@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/test: fix compilation error when debug mode enabled
Date: Mon, 26 Sep 2016 19:14:04 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C9FE525@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1474897968-27642-1-git-send-email-arkadiuszx.kusztal@intel.com>
Hi Arek,
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Monday, September 26, 2016 6:53 AM
> To: dev@dpdk.org
> Cc: Trahe, Fiona; Jain, Deepak K; De Lara Guarch, Pablo; Griffin, John; Kusztal,
> ArkadiuszX
> Subject: [PATCH] app/test: fix compilation error when debug mode enabled
>
> This patch fixes compilation error in test_cryptodev.c when
> RTE_LOG_DEBUG is specified
>
> Fixes: ba0dda7a7100 ("app/test: add GMAC authentication tests to cryptodev
> tests")
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> app/test/test_cryptodev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index d744b37..609908b 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -4288,7 +4288,7 @@ static int create_gmac_session(uint8_t dev_id,
> ut_params->cipher_xform.cipher.key.data = cipher_key;
> ut_params->cipher_xform.cipher.key.length = tdata->key.len;
>
> - TEST_HEXDUMP(stdout, "key:", key, key_len);
> + TEST_HEXDUMP(stdout, "key:", cipher_key, tdata->key.len);
>
> ut_params->auth_xform.type = RTE_CRYPTO_SYM_XFORM_AUTH;
> ut_params->auth_xform.next = NULL;
> @@ -4430,8 +4430,6 @@ test_AES_GMAC_authentication_verify(const struct
> gmac_test_data *tdata)
> TEST_ASSERT_EQUAL(ut_params->op->status,
> RTE_CRYPTO_OP_STATUS_SUCCESS,
> "crypto op processing failed");
>
> - TEST_HEXDUMP(stdout, "auth tag:", auth_tag, tdata->gmac_tag.len);
This removal is not related to this fix. If you want to remove it, better to send it in another patch.
Thanks,
Pablo
> -
> return 0;
>
> }
> --
> 2.1.0
next prev parent reply other threads:[~2016-09-26 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 13:52 Arek Kusztal
2016-09-26 14:11 ` Jain, Deepak K
2016-09-26 19:14 ` De Lara Guarch, Pablo [this message]
2016-09-27 10:02 ` Kusztal, ArkadiuszX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C9FE525@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).