* [dpdk-dev] [PATCH] app/test: remove unnecessary conditional
@ 2016-09-26 22:13 Pablo de Lara
2016-09-27 10:07 ` Trahe, Fiona
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2016-09-26 22:13 UTC (permalink / raw)
To: dev; +Cc: Pablo de Lara
Regardless the result of the conditional, the true and false
statements were the same, so the conditional can be removed.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
app/test/test_cryptodev.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index d744b37..514689d 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -341,10 +341,7 @@ ut_setup(void)
/* Reconfigure device to default parameters */
ts_params->conf.nb_queue_pairs = DEFAULT_NUM_QPS_PER_QAT_DEVICE;
ts_params->conf.socket_id = SOCKET_ID_ANY;
- ts_params->conf.session_mp.nb_objs =
- (gbl_cryptodev_type == RTE_CRYPTODEV_QAT_SYM_PMD) ?
- DEFAULT_NUM_OPS_INFLIGHT :
- DEFAULT_NUM_OPS_INFLIGHT;
+ ts_params->conf.session_mp.nb_objs = DEFAULT_NUM_OPS_INFLIGHT;
TEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0],
&ts_params->conf),
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/test: remove unnecessary conditional
2016-09-26 22:13 [dpdk-dev] [PATCH] app/test: remove unnecessary conditional Pablo de Lara
@ 2016-09-27 10:07 ` Trahe, Fiona
2016-09-28 0:13 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Trahe, Fiona @ 2016-09-27 10:07 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev; +Cc: De Lara Guarch, Pablo, Trahe, Fiona
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Monday, September 26, 2016 11:13 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH] app/test: remove unnecessary conditional
>
> Regardless the result of the conditional, the true and false statements were
> the same, so the conditional can be removed.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/test: remove unnecessary conditional
2016-09-27 10:07 ` Trahe, Fiona
@ 2016-09-28 0:13 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2016-09-28 0:13 UTC (permalink / raw)
To: Trahe, Fiona, dev
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Tuesday, September 27, 2016 3:07 AM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Trahe, Fiona
> Subject: RE: [dpdk-dev] [PATCH] app/test: remove unnecessary conditional
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Monday, September 26, 2016 11:13 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev] [PATCH] app/test: remove unnecessary conditional
> >
> > Regardless the result of the conditional, the true and false statements were
> > the same, so the conditional can be removed.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: <fiona.trahe@intel.com>
Applied to dpdk-next-crypto.
Pablo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-28 0:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-26 22:13 [dpdk-dev] [PATCH] app/test: remove unnecessary conditional Pablo de Lara
2016-09-27 10:07 ` Trahe, Fiona
2016-09-28 0:13 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).