From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 7BF476CBC for ; Wed, 5 Oct 2016 08:26:35 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 04 Oct 2016 23:26:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,447,1473145200"; d="scan'208";a="16342404" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga005.fm.intel.com with ESMTP; 04 Oct 2016 23:26:32 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by IRSMSX107.ger.corp.intel.com ([169.254.10.95]) with mapi id 14.03.0248.002; Wed, 5 Oct 2016 07:26:32 +0100 From: "De Lara Guarch, Pablo" To: Olivier Matz , "dev@dpdk.org" Thread-Topic: [PATCH v2 4/8] app/testpmd: add option to enable lro Thread-Index: AQHSCm+o57jkxslmWkuT7FvVrmhUQKCZjc1Q Date: Wed, 5 Oct 2016 06:26:31 +0000 Message-ID: References: <1473407734-11253-1-git-send-email-olivier.matz@6wind.com> <1473407734-11253-5-git-send-email-olivier.matz@6wind.com> In-Reply-To: <1473407734-11253-5-git-send-email-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGQzNTEzMjQtY2U2MC00NDhhLTk1ODAtZWJmYjA3ZDI3ZGExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkhoQmdNNCtlQ1ZmZWp6UHdBSkd3K2RKSXJIbVBoRmxvNzFoeXhLK3lSNDA9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 4/8] app/testpmd: add option to enable lro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 06:26:36 -0000 Hi Olivier, > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Friday, September 09, 2016 12:56 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2 4/8] app/testpmd: add option to enable lro >=20 > Introduce a new argument '--enable-lro' to ask testpmd to enable the LRO > feature on enabled ports, like it's done for '--enable-rx-cksum' for > instance. >=20 > Signed-off-by: Olivier Matz > --- > app/test-pmd/parameters.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > index 8792c2c..612ad37 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -150,6 +150,7 @@ usage(char* progname) > "If the drop-queue doesn't exist, the packet is dropped. " > "By default drop-queue=3D127.\n"); > printf(" --crc-strip: enable CRC stripping by hardware.\n"); > + printf(" --enable-lro: enable large receive offload.\n"); > printf(" --enable-rx-cksum: enable rx hardware checksum > offload.\n"); > printf(" --disable-hw-vlan: disable hardware vlan.\n"); > printf(" --disable-hw-vlan-filter: disable hardware vlan filter.\n"); > @@ -525,6 +526,7 @@ launch_args_parse(int argc, char** argv) > { "pkt-filter-size", 1, 0, 0 }, > { "pkt-filter-drop-queue", 1, 0, 0 }, > { "crc-strip", 0, 0, 0 }, > + { "enable-lro", 0, 0, 0 }, > { "enable-rx-cksum", 0, 0, 0 }, > { "enable-scatter", 0, 0, 0 }, > { "disable-hw-vlan", 0, 0, 0 }, > @@ -765,6 +767,8 @@ launch_args_parse(int argc, char** argv) > } > if (!strcmp(lgopts[opt_idx].name, "crc-strip")) > rx_mode.hw_strip_crc =3D 1; > + if (!strcmp(lgopts[opt_idx].name, "enable-lro")) > + rx_mode.enable_lro =3D 1; > if (!strcmp(lgopts[opt_idx].name, "enable-scatter")) > rx_mode.enable_scatter =3D 1; > if (!strcmp(lgopts[opt_idx].name, "enable-rx-cksum")) > -- > 2.8.1 Could you add this new parameter in the testpmd documentation? Thanks, Pablo