From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id 39FA72BEA
for <dev@dpdk.org>; Fri, 7 Oct 2016 05:51:14 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by fmsmga103.fm.intel.com with ESMTP; 06 Oct 2016 20:51:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,454,1473145200"; d="scan'208";a="17560230"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
by orsmga004.jf.intel.com with ESMTP; 06 Oct 2016 20:51:11 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by
IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0248.002;
Fri, 7 Oct 2016 04:51:10 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v3] mbuf: add function to dump ol flag list
Thread-Index: AQHSH62+8agTF+FYwUmd2TR3mDLOdKCcWz2g
Date: Fri, 7 Oct 2016 03:51:09 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973CA05760@IRSMSX108.ger.corp.intel.com>
References: <1473407734-11253-2-git-send-email-olivier.matz@6wind.com>
<1475743376-10360-1-git-send-email-olivier.matz@6wind.com>
In-Reply-To: <1475743376-10360-1-git-send-email-olivier.matz@6wind.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDI1OGZmZjgtNTI4ZC00NmY2LTk1MTUtMThhMWJkYzg3YzM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InZ4SDJjOHJwczlmNWlhYmZWVWw5Znk1cFVnK1c4Z29ENVJDSTM1cWhlYVk9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3] mbuf: add function to dump ol flag list
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Oct 2016 03:51:14 -0000
> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Thursday, October 06, 2016 1:43 AM
> To: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH v3] mbuf: add function to dump ol flag list
>=20
> The functions rte_get_rx_ol_flag_name() and rte_get_tx_ol_flag_name()
> can dump one flag, or set of flag that are part of the same mask (ex:
> PKT_TX_UDP_CKSUM, part of PKT_TX_L4_MASK). But they are not designed
> to
> dump the list of flags contained in mbuf->ol_flags.
>=20
> This commit introduce new functions to do that. Similarly to the packet
> type dump functions, the goal is to factorize the code that could be
> used in several applications and reduce the risk of desynchronization
> between the flags and the dump functions.
>=20
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Hi Olivier,
Sorry, I missed a typo in this patch: "ouput" -> "output".
Also, check-git-log.sh is complaining about two patches:
Wrong headline lowercase:
app/testpmd: dump rx flags in csum engine
app/testpmd: display rx port in csum engine
Lastly, could you send another version of the patchset (including patches w=
ithout any modifications).
In my opinion, it is a bit difficult to apply the patchset, because Patchwo=
rk doesn't tell me
that this patch is the first patch of the patchset.
The rest of the patches look ok to me.
Thanks,
Pablo