From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/4] testpmd: Add support to configure 25G and 50G speeds
Date: Wed, 12 Oct 2016 01:24:07 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973CA07C47@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973CA07C0F@IRSMSX108.ger.corp.intel.com>
Hi,
> From: Ajit Khaparde [mailto:ajit.khaparde@broadcom.com]
> Sent: Monday, October 10, 2016 11:41 AM
> To: Yigit, Ferruh
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: Re: [dpdk-dev] [PATCH 1/4] testpmd: Add support to configure 25G
> and 50G speeds
>
> On Mon, Oct 10, 2016 at 10:01 AM, Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> Hi Ajit,
>
> On 9/29/2016 6:03 PM, Ajit Khaparde wrote:
> > Support to configure 25G and 50G speeds is missing from testpmd.
> > This patch also updates the testpmd user guide accordingly.
> >
> > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> This patch seems not really part of the patchset for bnxt driver, but
> standalone testpmd only modification,
>
> and can be threaded as single patch.
> OK. Got it.
> I had worked on this change in the middle of other things.
> So it got bundled along with other bnxt patches.
>
>
> I am adding testpmd maintainer to cc.
> Let me know if you want me to send it again as a standalone patch.
Yes, I think it is a good idea.
Apart from that, there are a couple of things to fix:
There are two lines that exceed the character limit (from checkpatch):
WARNING: line over 80 characters
#55: FILE: app/test-pmd/cmdline.c:1084:
+ .help_str = "port config all speed 10|100|1000|10000|25000|40000|50000|100000|auto duplex "
WARNING: line over 80 characters
#73: FILE: app/test-pmd/cmdline.c:1159:
+ .help_str = "port config X speed 10|100|1000|10000|25000|40000|50000|100000|auto duplex "
check-git-log.sh complains about the title:
Wrong headline label:
testpmd: Add support to configure 25G and 50G speeds
Wrong headline uppercase:
testpmd: Add support to configure 25G and 50G speeds
Title should be "app/testpmd: add ...."
Could you send a separate v2 with this changes?
And probably change the bnxt patchset to 3 patches only.
Thanks,
Pablo
next prev parent reply other threads:[~2016-10-12 1:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 17:03 Ajit Khaparde
2016-10-10 15:01 ` Ferruh Yigit
2016-10-10 18:40 ` Ajit Khaparde
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8973CA07C0F@IRSMSX108.ger.corp.intel.com>
2016-10-12 1:24 ` De Lara Guarch, Pablo [this message]
2016-10-12 21:26 ` [dpdk-dev] [PATCH v2] app/testpmd: add " Ajit Khaparde
2016-10-13 15:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973CA07C47@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).