From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Jan Blunck <jblunck@infradead.org>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] drivers: add name alias registration for rte_driver
Date: Fri, 21 Oct 2016 18:31:41 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973CA172DB@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1476956223-30308-1-git-send-email-jblunck@infradead.org>
> -----Original Message-----
> From: Jan Blunck [mailto:jblunck@gmail.com] On Behalf Of Jan Blunck
> Sent: Thursday, October 20, 2016 2:37 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; thomas.monjalon@6wind.com;
> yuanhan.liu@linux.intel.com; Mcnamara, John
> Subject: [PATCH 1/2] drivers: add name alias registration for rte_driver
>
> This adds infrastructure for drivers to allow being requested by an alias
> so that a renamed driver can still get loaded by its legacy name.
>
> Signed-off-by: Jan Blunck <jblunck@infradead.org>
Hi Jan,
I saw two checkpatch errors in this patch that should be fixed:
ERROR: "foo * bar" should be "foo *bar"
#55: FILE: lib/librte_eal/common/include/rte_vdev.h:86:
+static const char * vdrvinit_ ## nm ## _alias;\
ERROR: "foo * bar" should be "foo *bar"
#65: FILE: lib/librte_eal/common/include/rte_vdev.h:96:
+static const char * vdrvinit_ ## nm ## _alias = RTE_STR(alias)
total: 2 errors, 0 warnings, 39 lines checked
Thanks,
Pablo
next prev parent reply other threads:[~2016-10-21 18:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 9:37 Jan Blunck
2016-10-20 9:37 ` [dpdk-dev] [PATCH 2/2] drivers: register aliases for renamed VDEV drivers Jan Blunck
2016-10-21 0:15 ` De Lara Guarch, Pablo
2016-10-21 11:22 ` [dpdk-dev] [PATCH] drivers: register aliases for renamed cryptodev drivers Jan Blunck
2016-10-21 18:35 ` De Lara Guarch, Pablo
2016-10-21 18:33 ` [dpdk-dev] [PATCH 2/2] drivers: register aliases for renamed VDEV drivers De Lara Guarch, Pablo
2016-10-21 18:31 ` De Lara Guarch, Pablo [this message]
2016-10-22 11:24 ` [dpdk-dev] [PATCH 1/2] drivers: add name alias registration for rte_driver Maxime Coquelin
2016-10-24 16:22 ` [dpdk-dev] [PATCH v2 1/3] " Jan Blunck
2016-10-24 16:22 ` [dpdk-dev] [PATCH v2 2/3] drivers: register aliases for renamed VDEV drivers Jan Blunck
2016-10-24 16:22 ` [dpdk-dev] [PATCH v2 3/3] drivers: register aliases for renamed cryptodev drivers Jan Blunck
2016-10-24 17:41 ` [dpdk-dev] [PATCH v2 1/3] drivers: add name alias registration for rte_driver Yuanhan Liu
2016-10-25 16:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973CA172DB@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=jblunck@infradead.org \
--cc=john.mcnamara@intel.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).