From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0FC802B91; Fri, 6 Jan 2017 11:27:09 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP; 06 Jan 2017 02:27:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="50770143" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga006.fm.intel.com with ESMTP; 06 Jan 2017 02:27:08 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by IRSMSX106.ger.corp.intel.com ([169.254.8.197]) with mapi id 14.03.0248.002; Fri, 6 Jan 2017 10:27:06 +0000 From: "De Lara Guarch, Pablo" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" , "stable@dpdk.org" CC: "Trahe, Fiona" , "Griffin, John" , "Jain, Deepak K" , "Doherty, Declan" Thread-Topic: [PATCH v2 1/3] crypto/aesni_gcm: fix J0 padding bytes for GCM Thread-Index: AQHSXPYRFZU2OqNKwU+xqeoQPEKgnKErVG/A Date: Fri, 6 Jan 2017 10:27:06 +0000 Message-ID: References: <1482481493-4369-1-git-send-email-arkadiuszx.kusztal@intel.com> <1482481493-4369-2-git-send-email-arkadiuszx.kusztal@intel.com> In-Reply-To: <1482481493-4369-2-git-send-email-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjIwNWE2MDctYjA1My00M2Q0LWE2MDYtNWQxNmUwZDZkMjQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ink2RGFBempMeHdWTDY5cEcwcU1WbEhcL0JQNWo5czY2cHRyZjhhdDZOZDBFPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: fix J0 padding bytes for GCM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2017 10:27:10 -0000 CC'ing stable mailing list. > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Friday, December 23, 2016 8:25 AM > To: dev@dpdk.org > Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K; > Doherty, Declan; Kusztal, ArkadiuszX > Subject: [PATCH v2 1/3] crypto/aesni_gcm: fix J0 padding bytes for GCM >=20 > This commit fixes pre-counter block (J0) padding by clearing > four most significant bytes before setting initial counter value. >=20 > Fixes: b2bb3597470c ("crypto/aesni_gcm: move pre-counter block to > driver") >=20 > Signed-off-by: Arek Kusztal > --- > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > index dba5e15..af3d60f 100644 > --- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > +++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > @@ -40,6 +40,7 @@ > #include > #include > #include > +#include >=20 > #include "aesni_gcm_pmd_private.h" >=20 > @@ -241,7 +242,8 @@ process_gcm_crypto_op(struct aesni_gcm_qp *qp, > struct rte_crypto_sym_op *op, > * to set BE LSB to 1, driver expects that 16B is allocated > */ > if (op->cipher.iv.length =3D=3D 12) { > - op->cipher.iv.data[15] =3D 1; > + uint32_t *iv_padd =3D (uint32_t *)&op->cipher.iv.data[12]; > + *iv_padd =3D rte_bswap32(1); > } >=20 > if (op->auth.aad.length !=3D 12 && op->auth.aad.length !=3D 8 && > -- > 2.1.0