From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 1A2A62A6C
 for <dev@dpdk.org>; Fri,  6 Jan 2017 13:21:55 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP; 06 Jan 2017 04:21:54 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="1108823161"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by fmsmga002.fm.intel.com with ESMTP; 06 Jan 2017 04:21:54 -0800
Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by
 IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Fri, 6 Jan 2017 12:21:53 +0000
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by
 irsmsx111.ger.corp.intel.com ([169.254.2.109]) with mapi id 14.03.0248.002;
 Fri, 6 Jan 2017 12:21:53 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
CC: "Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>, "Doherty, Declan"
 <declan.doherty@intel.com>, "Kerlin, Marcin" <marcin.kerlin@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for
 new	performance test application
Thread-Index: AQHSZ2OI03BprsjHxkKpzaRYrhM9q6ErWqDw
Date: Fri, 6 Jan 2017 12:21:52 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897476BF528@IRSMSX108.ger.corp.intel.com>
References: <1480691702-4600-1-git-send-email-michalx.k.jastrzebski@intel.com>
 <1483635001-15473-1-git-send-email-slawomirx.mrozowicz@intel.com>
 <1483635001-15473-3-git-send-email-slawomirx.mrozowicz@intel.com>
In-Reply-To: <1483635001-15473-3-git-send-email-slawomirx.mrozowicz@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTgwNDM0NmEtZjI1ZS00MjA3LThjNDAtZjAzOTZkZmNjZDQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlhJeVFOekI4d2c4R2R4K0VjR0g4S0Mrb3pMUFpOd08rM29VMkZHNUN6Uzg9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for
 new	performance test application
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jan 2017 12:21:56 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Slawomir
> Mrozowicz
> Sent: Thursday, January 05, 2017 4:50 PM
> To: dev@dpdk.org
> Cc: Mrozowicz, SlawomirX; Doherty, Declan; Kerlin, Marcin
> Subject: [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for ne=
w
> performance test application
>=20
> This patch adds helper functions for new performance application.
> Application can be used to measute throughput and latency of
> cryptography operation performed by crypto device.
>=20
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>

Hi Slawomir,

You should change the title of this patch to something like: "cryptodev: ad=
d functions for...".
Also, maybe it would be better to say "add functions to retrieve device inf=
o",
since you are not saying much with the current title.

I have seen also that this is based on the SGL code, so this patch didn't a=
pply cleanly.
Next time, specify it in the email the dependencies of the patch.

Thanks,
Pablo