From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5ABE61094 for ; Mon, 9 Jan 2017 14:56:22 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP; 09 Jan 2017 05:56:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="51134868" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga005.fm.intel.com with ESMTP; 09 Jan 2017 05:56:20 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by IRSMSX154.ger.corp.intel.com ([169.254.12.40]) with mapi id 14.03.0248.002; Mon, 9 Jan 2017 13:55:41 +0000 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "Mcnamara, John" , "nhorman@tuxdriver.com" , Horia Geanta Neag Thread-Topic: [PATCH v2 02/11] crypto/dpaa2_sec: Run time assembler for Descriptor formation Thread-Index: AQHSXGLtVygIg1MeCke6WbF5fE5QJqEwQ1Hw Date: Mon, 9 Jan 2017 13:55:40 +0000 Message-ID: References: <20161205125540.6419-1-akhil.goyal@nxp.com> <20161222201700.20020-1-akhil.goyal@nxp.com> <20161222201700.20020-3-akhil.goyal@nxp.com> In-Reply-To: <20161222201700.20020-3-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzA0NjI3OTUtMDA1Mi00ZDhkLTkwM2YtZDhiYWYwNzdlNjllIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkU4YU9objFlOUlnR2tFWDlFTWtsWnE0ZFk3VGNybmNCV3l3YVwvME8rN1RBPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 02/11] crypto/dpaa2_sec: Run time assembler for Descriptor formation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 13:56:23 -0000 > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Thursday, December 22, 2016 8:17 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > hemant.agrawal@nxp.com; Mcnamara, John; nhorman@tuxdriver.com; > Akhil Goyal; Horia Geanta Neag > Subject: [PATCH v2 02/11] crypto/dpaa2_sec: Run time assembler for > Descriptor formation >=20 > A set of header files(hw) which helps in making the descriptors > that are understood by NXP's SEC hardware. > This patch provides header files for command words which can be used > for descriptor formation. >=20 > Signed-off-by: Horia Geanta Neag > Acked-by: Akhil Goyal > --- ... > diff --git a/drivers/crypto/dpaa2_sec/hw/rta.h > b/drivers/crypto/dpaa2_sec/hw/rta.h > new file mode 100644 > index 0000000..7eb0455 > --- /dev/null > +++ b/drivers/crypto/dpaa2_sec/hw/rta.h ... > +extern enum rta_sec_era rta_sec_era; > + > +/** > + * rta_set_sec_era - Set SEC Era HW block revision for which the RTA > library > + * will generate the descriptors. > + * @era: SEC Era (enum rta_sec_era) > + * > + * Return: 0 if the ERA was set successfully, -1 otherwise (int) > + * > + * Warning 1: Must be called *only once*, *before* using any other RTA > API > + * routine. > + * > + * Warning 2: *Not thread safe*. > + */ > +static inline int rta_set_sec_era(enum rta_sec_era era) > +{ "static inline int" should go in a different line than the function name an= d parameters. So it should be: static inline int rta_set_sec_era(enum rta_sec_era era) { Could you make this change here and in the rest of the functions? Thanks, Pablo