From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 28EC937B6 for ; Fri, 13 Jan 2017 15:02:24 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 13 Jan 2017 04:35:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,221,1477983600"; d="scan'208";a="212944263" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga004.fm.intel.com with ESMTP; 13 Jan 2017 04:35:17 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by IRSMSX101.ger.corp.intel.com ([169.254.1.112]) with mapi id 14.03.0248.002; Fri, 13 Jan 2017 12:35:16 +0000 From: "De Lara Guarch, Pablo" To: "Yang, Qiming" , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities query Thread-Index: AQHSbISHcvMZ81sJI0a7wgsOSg5rDqE2FOkAgAAUL4CAAC8OEA== Date: Fri, 13 Jan 2017 12:35:15 +0000 Message-ID: References: <1482485513-7087-1-git-send-email-qiming.yang@intel.com> <1484191582-17293-1-git-send-email-qiming.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzE5Yjc1OWYtNWM1My00NzlmLWEwYjctODY3OTg3OTYyYzEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImNRTnRFUTZBa2hReGN5SUxVYVV2ZDBMZnRiYm5YcTNFU1VKaWRmTXVVMU09In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 14:02:24 -0000 Hi Qiming, > -----Original Message----- > From: Yang, Qiming > Sent: Friday, January 13, 2017 9:40 AM > To: De Lara Guarch, Pablo; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5] app/testpmd: supported offload > capabilities query >=20 > Hi, Pablo >=20 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, January 13, 2017 4:43 PM > To: Yang, Qiming ; dev@dpdk.org > Cc: Yang, Qiming > Subject: RE: [dpdk-dev] [PATCH v5] app/testpmd: supported offload > capabilities query >=20 > Hi Qiming, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang > > Sent: Thursday, January 12, 2017 3:26 AM > > To: dev@dpdk.org > > Cc: Yang, Qiming > > Subject: [dpdk-dev] [PATCH v5] app/testpmd: supported offload > > capabilities query > > > > Add two new commands "show port cap " and "show port cap > all"to > > diaplay what offload capabilities supported in ports. It will not only > > display all the capabilities of the port, but also the enabling > > condition for each capability in the running time. > > > > Signed-off-by: Qiming Yang > > Acked-by: Jingjing Wu > > Acked-by: Beilei Xing > > --- > > v2 changes: > > * fixed the output style as Ferruh's patch show and add some > > description in docs for new functions. > > v3 changes: > > * add new command in cmd_help_long_parsed. > > v4 changes: > > * use 'cap' instead of 'capa'. > > v5 changes: > > * rebased, fixed the inappropriate expression and adjusted the > > output order. > > --- > > --- > > app/test-pmd/cmdline.c | 17 ++- > > app/test-pmd/config.c | 175 > > ++++++++++++++++++++++++++++ > > app/test-pmd/testpmd.h | 1 + > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +- > > 4 files changed, 195 insertions(+), 10 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 4e8b0d8..6fa1783 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c >=20 > ... >=20 > > + > > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_CKSUM) { > > + printf("RX TCP checksum: "); > > + if (dev->data->dev_conf.rxmode.hw_ip_checksum) > > + printf("on\n"); > > + else > > + printf("off\n"); > > + } > > + > > + if (dev_info.rx_offload_capa & > > DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM) > > + printf("RX Outer IPv4 checksum: "); >=20 > Missing on/off? > Qiming: I didn't find any switch for this feature in DPDK now. I'll fix t= he > format problem. Thank you. I just saw your v6. So, what does this mean? If the device is capable of do= ing this, but there is no way to enable/disable it, it would mean that it will be ena= bled or disabled by default, right? I see that X550 NIC is the only one capable of this. Maybe Wenzhuo can help= on clarifying this. I would say that, if it is enabled when it is capable, then you should prin= t "on", But printing only "RX Outer IPv4 checksum" does not give any information (w= hen all the rest of the capabilities show on/off). Thanks, Pablo =20