From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1A734FABE for ; Wed, 18 Jan 2017 18:07:02 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 18 Jan 2017 09:07:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,249,1477983600"; d="scan'208";a="1084510655" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 18 Jan 2017 09:05:47 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by IRSMSX103.ger.corp.intel.com ([163.33.3.157]) with mapi id 14.03.0248.002; Wed, 18 Jan 2017 17:05:46 +0000 From: "De Lara Guarch, Pablo" To: "zbigniew.bodek@caviumnetworks.com" , "dev@dpdk.org" CC: "Doherty, Declan" , "jerin.jacob@caviumnetworks.com" , "jianbo.liu@linaro.org" , "hemant.agrawal@nxp.com" Thread-Topic: [PATCH v5 4/7] doc: update documentation about ARMv8 crypto PMD Thread-Index: AQHScZcsLyuN8eCXakyzs8jD5sjq66E+dX3g Date: Wed, 18 Jan 2017 17:05:45 +0000 Message-ID: References: <1484668143-32522-3-git-send-email-zbigniew.bodek@caviumnetworks.com> <1484749650-24867-1-git-send-email-zbigniew.bodek@caviumnetworks.com> <1484749650-24867-5-git-send-email-zbigniew.bodek@caviumnetworks.com> In-Reply-To: <1484749650-24867-5-git-send-email-zbigniew.bodek@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODU5YzU1M2YtYmNmYS00MmRiLWI1YTMtZTQ2ODgyMDA0MzEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im9QeHJLVFF1MWNZT01tR0FmQ1JqQUh4Ylh6U2tDeGZzXC9QRzc0UTRZMFdNPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 4/7] doc: update documentation about ARMv8 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 17:07:03 -0000 Hi Bodek, > -----Original Message----- > From: zbigniew.bodek@caviumnetworks.com > [mailto:zbigniew.bodek@caviumnetworks.com] > Sent: Wednesday, January 18, 2017 2:27 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Doherty, Declan; > jerin.jacob@caviumnetworks.com; jianbo.liu@linaro.org; > hemant.agrawal@nxp.com; Zbigniew Bodek > Subject: [PATCH v5 4/7] doc: update documentation about ARMv8 crypto > PMD >=20 > From: Zbigniew Bodek >=20 > Add documentation about the driver and update > release notes. >=20 > Signed-off-by: Zbigniew Bodek > Reviewed-by: Jerin Jacob > --- > doc/guides/cryptodevs/armv8.rst | 96 > ++++++++++++++++++++++++++++++++++ > doc/guides/cryptodevs/index.rst | 1 + > doc/guides/rel_notes/release_17_02.rst | 5 ++ > 3 files changed, 102 insertions(+) > create mode 100644 doc/guides/cryptodevs/armv8.rst >=20 > diff --git a/doc/guides/cryptodevs/armv8.rst > b/doc/guides/cryptodevs/armv8.rst > new file mode 100644 > index 0000000..ca8781e > --- /dev/null > +++ b/doc/guides/cryptodevs/armv8.rst ... > + > +ARMv8 Crypto Poll Mode Driver > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D Extra "=3D=3D=3D" here. > + > +This code provides the initial implementation of the ARMv8 crypto PMD. > +The driver uses ARMv8 cryptographic extensions to process chained > crypto > +operations in an optimized way. The core functionality is provided by > +a low-level library, written in the assembly code. > + > +Features > +-------- > + > +ARMv8 Crypto PMD has support for the following algorithm pairs: > + > +Supported cipher algorithms: > +* ``RTE_CRYPTO_CIPHER_AES_CBC`` Add a blank like before starting a list (same below). > + > +Supported authentication algorithms: > +* ``RTE_CRYPTO_AUTH_SHA1_HMAC`` > +* ``RTE_CRYPTO_AUTH_SHA256_HMAC`` > + Could you add an entry on the "Crypto Device Supported Functionality Matric= es", to show supported algorithms and feature flags? It is in doc/guides/cryptod= evs/overview.rst. There should be a column per crypto device (I just realized that I missed one for ZUC PMD, so I will send a patch shor= tly, and then you can rebase it on top of it). The rest of the patchset looks good to me, so once you send another version= , I will merge it. Thanks, Pablo