From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3FE6EB6D for ; Fri, 27 Jan 2017 14:15:45 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 27 Jan 2017 05:15:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,295,1477983600"; d="scan'208";a="1099688651" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga001.fm.intel.com with ESMTP; 27 Jan 2017 05:15:41 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by irsmsx110.ger.corp.intel.com ([169.254.15.101]) with mapi id 14.03.0248.002; Fri, 27 Jan 2017 13:15:40 +0000 From: "De Lara Guarch, Pablo" To: "Doherty, Declan" CC: "dev@dpdk.org" Thread-Topic: [PATCH] crypto/aesni_mb: add missing digest length Thread-Index: AQHSeJ9AgTJuVWA0eUSTmVguwp3ybqFMTVKw Date: Fri, 27 Jan 2017 13:15:39 +0000 Message-ID: References: <1485522968-211005-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1485522968-211005-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDJkNzA5YzUtMTg3Ni00N2Y0LTljMDQtNmU0M2I4ZmM0ZGEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjdpWlRqYkl2WWU3SkYxcEVsS0tIbGJ3Z0ZQZUp4V0tnMm9WRERYaHh2Yk09In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 13:15:45 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, January 27, 2017 1:16 PM > To: adrien.mazarguil@6wind.com; Wu, Jingjing > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] crypto/aesni_mb: add missing digest length >=20 > AESNI MB now supports authentication only operations, > but the array containing all the possible digest lengths > was not updated to reflect the new algorithm NULL_HASH, > causing an "Out-of-bounds access". >=20 > Coverity issue: 140977 > Fixes: 8772c3f713e2 ("crypto/aesni_mb: add single operation > functionality") >=20 > Signed-off-by: Pablo de Lara > --- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h > b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h > index 5f125b2..eb4b2ad 100644 > --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h > +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h > @@ -88,6 +88,7 @@ static const unsigned > auth_truncated_digest_byte_lengths[] =3D { > [SHA_384] =3D 24, > [SHA_512] =3D 32, > [AES_XCBC] =3D 12, > + [NULL_HASH] =3D 0 > }; >=20 > /** > @@ -111,6 +112,7 @@ static const unsigned auth_digest_byte_lengths[] =3D > { > [SHA_384] =3D 48, > [SHA_512] =3D 64, > [AES_XCBC] =3D 16, > + [NULL_HASH] =3D 0 > }; >=20 > /** > -- > 2.7.4 Wrong maintainer, Sending to right one now. Sorry about that.