From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D817A11C5 for ; Tue, 21 Mar 2017 17:00:20 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 21 Mar 2017 09:00:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,198,1486454400"; d="scan'208";a="79003245" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga005.fm.intel.com with ESMTP; 21 Mar 2017 09:00:17 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by IRSMSX101.ger.corp.intel.com ([169.254.1.112]) with mapi id 14.03.0248.002; Tue, 21 Mar 2017 16:00:16 +0000 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "Doherty, Declan" , "Mcnamara, John" , "nhorman@tuxdriver.com" , "hemant.agrawal@nxp.com" , Cristian Sovaiala Thread-Topic: [PATCH v5 03/12] crypto/dpaa2_sec: add mc dpseci object support Thread-Index: AQHSlCnaQdKYtgngQ0OOY3UzfyC/xKGfi2Nw Date: Tue, 21 Mar 2017 16:00:16 +0000 Message-ID: References: <20170303193648.30665-1-akhil.goyal@nxp.com> <20170303194935.30831-1-akhil.goyal@nxp.com> <20170303194935.30831-4-akhil.goyal@nxp.com> In-Reply-To: <20170303194935.30831-4-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjNhOTRjMmQtYjY5Ny00ODNhLTkxNDItMzc0MmQ5YzJlOTU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlM5ellQQ3p3ZFgrdG9YenZVSUwxSTAzSDBtUUMybG1wMzZrMjJCbEFlc1E9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 03/12] crypto/dpaa2_sec: add mc dpseci object support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 16:00:22 -0000 > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Friday, March 03, 2017 7:49 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > Mcnamara, John; nhorman@tuxdriver.com; hemant.agrawal@nxp.com; > Akhil Goyal; Cristian Sovaiala > Subject: [PATCH v5 03/12] crypto/dpaa2_sec: add mc dpseci object support >=20 > add support for dpseci object in MC driver. > DPSECI represent a crypto object in DPAA2. >=20 > Signed-off-by: Cristian Sovaiala > Signed-off-by: Akhil Goyal > --- ... > diff --git a/drivers/crypto/dpaa2_sec/mc/dpseci.c > b/drivers/crypto/dpaa2_sec/mc/dpseci.c > new file mode 100644 > index 0000000..173a40c > --- /dev/null > +++ b/drivers/crypto/dpaa2_sec/mc/dpseci.c > @@ -0,0 +1,527 @@ > +/* Copyright 2013-2016 Freescale Semiconductor Inc. > + * Copyright (c) 2016 NXP. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions ar= e > met: > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in the > + * documentation and/or other materials provided with the distribution. > + * * Neither the name of the above-listed copyright holders nor the > + * names of any contributors may be used to endorse or promote > products > + * derived from this software without specific prior written permission. > + * > + * > + * ALTERNATIVELY, this software may be distributed under the terms of > the > + * GNU General Public License ("GPL") as published by the Free Software > + * Foundation, either version 2 of that License or (at your option) any > + * later version. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > CONTRIBUTORS "AS IS" > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > LIMITED TO, THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A > PARTICULAR PURPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR > CONTRIBUTORS BE > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, > OR > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, > PROCUREMENT OF > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR > BUSINESS > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, > WHETHER IN > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR > OTHERWISE) > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF > ADVISED OF THE > + * POSSIBILITY OF SUCH DAMAGE. > + */ Blank line here. Make this change in the rest of the file (and possibly oth= er files). > +#include > +#include > +#include > +#include > + > +int dpseci_open(struct fsl_mc_io *mc_io, Return type goes in a separate line. Make this change in the rest of the fi= le (and possibly other files). > + uint32_t cmd_flags, > + int dpseci_id, > + uint16_t *token) > +{ > + struct mc_command cmd =3D { 0 }; > + int err; > + > + /* prepare command */ > + cmd.header =3D mc_encode_cmd_header(DPSECI_CMDID_OPEN, > + cmd_flags, > + 0); > + DPSECI_CMD_OPEN(cmd, dpseci_id); > + > + /* send command to mc*/ Extra space before *, and remove it after it. Make this change in the rest = of the file (and possibly other files). > + err =3D mc_send_command(mc_io, &cmd); > + if (err) > + return err; > + > + /* retrieve response parameters */ > + *token =3D MC_CMD_HDR_READ_TOKEN(cmd.header); > + > + return 0; > +} > + > +int dpseci_close(struct fsl_mc_io *mc_io, > + uint32_t cmd_flags, > + uint16_t token) > +{ > + struct mc_command cmd =3D { 0 }; > + > + /* prepare command */ > + cmd.header =3D mc_encode_cmd_header(DPSECI_CMDID_CLOSE, > + cmd_flags, > + token); > + > + /* send command to mc*/ > + return mc_send_command(mc_io, &cmd); > +} > + > +int dpseci_create(struct fsl_mc_io *mc_io, > + uint16_t dprc_token, > + uint32_t cmd_flags, > + const struct dpseci_cfg *cfg, > + uint32_t *obj_id) Indentation looks weird here. Remove the tabs between the variable type and= name or indent all at the same level. Make this change in the rest of the file (and possibly other files). ... > diff --git a/drivers/crypto/dpaa2_sec/mc/fsl_dpseci.h > b/drivers/crypto/dpaa2_sec/mc/fsl_dpseci.h > new file mode 100644 > index 0000000..644e30c > --- /dev/null > +++ b/drivers/crypto/dpaa2_sec/mc/fsl_dpseci.h > @@ -0,0 +1,661 @@ ... > +/** > + * dpseci_open() - Open a control session for the specified object > + * @mc_io: Pointer to MC portal's I/O object > + * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_' > + * @dpseci_id: DPSECI unique ID > + * @token: Returned token; use in subsequent API calls > + * > + * This function can be used to open a control session for an > + * already created object; an object may have been declared in > + * the DPL or by calling the dpseci_create() function. > + * This function returns a unique authentication token, > + * associated with the specific object ID and the specific MC > + * portal; this token must be used in all subsequent commands for > + * this specific object. > + * > + * Return: '0' on Success; Error code otherwise. > + */ Even though this is not a public function (at least, that's what I think), You should follow the standard way to include function comments, using @par= am and @return. Look at other header files.