From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B4153FADB for ; Wed, 29 Mar 2017 21:26:47 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 29 Mar 2017 12:26:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,242,1486454400"; d="scan'208";a="1113385795" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 29 Mar 2017 12:26:45 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Wed, 29 Mar 2017 20:26:44 +0100 From: "De Lara Guarch, Pablo" To: Akhil Goyal CC: "dev@dpdk.org" Thread-Topic: [PATCH v6 04/13] crypto/dpaa2_sec: add basic crypto operations Thread-Index: AQHSpOnUtDc4DmZt70Gw0/CJtSfVMKGoudtAgALecoCAAKE6oA== Date: Wed, 29 Mar 2017 19:26:43 +0000 Message-ID: References: <20170303194935.30831-1-akhil.goyal@nxp.com> <20170324215754.21751-1-akhil.goyal@nxp.com> <20170324215754.21751-5-akhil.goyal@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQ5MjAxODYtZTk2Ni00OGNiLWE1ODgtOWQwNmZiMWI4YzEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZ2Rk0xTTNkU0RCNEhSRFBlanhUTTh0bWhXdVZ3dDVhckYyYld0NGdyS1U9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 04/13] crypto/dpaa2_sec: add basic crypto operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 19:26:48 -0000 > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Wednesday, March 29, 2017 11:45 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [PATCH v6 04/13] crypto/dpaa2_sec: add basic crypto > operations >=20 > On 3/27/2017 7:28 PM, De Lara Guarch, Pablo wrote: > > > > > >> -----Original Message----- > >> From: akhil.goyal@nxp.com [mailto:akhil.goyal@nxp.com] > >> Sent: Friday, March 24, 2017 9:58 PM > >> To: dev@dpdk.org > >> Cc: thomas.monjalon@6wind.com; Doherty, Declan; De Lara Guarch, > Pablo; > >> Mcnamara, John; nhorman@tuxdriver.com; hemant.agrawal@nxp.com; > >> Akhil Goyal > >> Subject: [PATCH v6 04/13] crypto/dpaa2_sec: add basic crypto > operations > >> > >> From: Akhil Goyal > >> > >> Signed-off-by: Hemant Agrawal > >> Signed-off-by: Akhil Goyal > >> --- > >> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 181 > >> ++++++++++++++++++++++++++++ > >> 1 file changed, 181 insertions(+) > >> > >> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > >> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > >> index 378df4a..aa08922 100644 > > > > ... > > > >> + > >> +static int > >> +dpaa2_sec_dev_configure(struct rte_cryptodev *dev __rte_unused) > >> +{ > >> + PMD_INIT_FUNC_TRACE(); > >> + > >> + return -ENOTSUP; > >> +} > >> + > > > > There have been an API change here, so this configure function has > another parameter, "struct rte_cryptodev_config". > > > > If you need to send another version, make the change (rebase against > latest subtree). If not, I will make the change for you. > > > > Thanks, > > Pablo > > > > > There is nothing pending from my side for this patch set. Please let me > know if there are any more comments. Hi Akhil, I am waiting for the network drivers to be applied in mainline, as your patchset depends on the dpaa2 network driver. Thanks, Pablo =20 >=20 > Regards, > Akhil