From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 36D515320 for ; Thu, 30 Mar 2017 23:29:24 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP; 30 Mar 2017 14:29:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,248,1486454400"; d="scan'208";a="1129078180" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 30 Mar 2017 14:29:21 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by IRSMSX103.ger.corp.intel.com ([169.254.3.241]) with mapi id 14.03.0319.002; Thu, 30 Mar 2017 22:29:18 +0100 From: "De Lara Guarch, Pablo" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "Trahe, Fiona" , "Griffin, John" , "Jain, Deepak K" Thread-Topic: [PATCH v2 3/3] test: add ZUC test cases for QAT Thread-Index: AQHSqI0Jh/kNrZ+3306HFozgc4K/bKGt5dIA Date: Thu, 30 Mar 2017 21:29:18 +0000 Message-ID: References: <1490792659-31544-1-git-send-email-arkadiuszx.kusztal@intel.com> <1490792659-31544-4-git-send-email-arkadiuszx.kusztal@intel.com> In-Reply-To: <1490792659-31544-4-git-send-email-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTIyMDhkYjctMDI5Zi00MTY3LWI0MTItM2JhNWEyMjUxOWFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImsyV2JDanRzbWNRaGhSU20rVHRFSVZ5cENHMzBFaVI2SEFXSFwvQWNCQjJZPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] test: add ZUC test cases for QAT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 21:29:25 -0000 Hi Arek, > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, March 29, 2017 2:04 PM > To: dev@dpdk.org > Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K; > Kusztal, ArkadiuszX > Subject: [PATCH v2 3/3] test: add ZUC test cases for QAT >=20 > This patch adds ZUC EEA3/EIA3 test cases for QAT crypto > test suite and consolidate ZUC test vectors into one header file. >=20 > Signed-off-by: Arek Kusztal > diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c > index a8f3ae5..7507878 100644 > --- a/test/test/test_cryptodev.c > +++ b/test/test/test_cryptodev.c ... > static int > +test_zuc_cipher_auth(const struct wireless_test_data *tdata) > +{ > + struct crypto_testsuite_params *ts_params =3D &testsuite_params; > + struct crypto_unittest_params *ut_params =3D &unittest_params; > + > + int retval; > + > + uint8_t *plaintext, *ciphertext; > + unsigned int plaintext_pad_len; > + unsigned int plaintext_len; This test (and the encryption and auth only tests) will fail if using a QAT= device without ZUC support. I suggest to check the capabilities of the device to see if it supports ZUC and if it doesn't, return -ENOTSUP. Also, I would move the vectors from one file to another in another patch. Thanks, Pablo