From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"Griffin, John" <john.griffin@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] crypto/qat: refactor capabilities infrastructure
Date: Thu, 30 Mar 2017 21:50:46 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89747712AFD@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1490792659-31544-2-git-send-email-arkadiuszx.kusztal@intel.com>
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, March 29, 2017 2:04 PM
> To: dev@dpdk.org
> Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K;
> Kusztal, ArkadiuszX
> Subject: [PATCH v2 1/3] crypto/qat: refactor capabilities infrastructure
>
> Refactor capabilities data structures to facilitate
> defining different capability sets for different devices
> without duplication of data.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> drivers/crypto/qat/qat_crypto.c | 532 ++-------------------------
> drivers/crypto/qat/qat_crypto.h | 3 +
> drivers/crypto/qat/qat_crypto_capabilities.h | 510
> +++++++++++++++++++++++++
> drivers/crypto/qat/rte_qat_cryptodev.c | 24 ++
> 4 files changed, 577 insertions(+), 492 deletions(-)
> create mode 100644 drivers/crypto/qat/qat_crypto_capabilities.h
>
> diff --git a/drivers/crypto/qat/qat_crypto.c
> b/drivers/crypto/qat/qat_crypto.c
> index 9310211..9678a70 100644
> --- a/drivers/crypto/qat/qat_crypto.c
> +++ b/drivers/crypto/qat/qat_crypto.c
> @@ -69,497 +69,45 @@
>
> #define BYTE_LENGTH 8
>
> -static const struct rte_cryptodev_capabilities qat_pmd_capabilities[] = {
> - { /* SHA1 HMAC */
> - .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> - {.sym = {
> - .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
> - {.auth = {
> - .algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
> - .block_size = 64,
> - .key_size = {
> - .min = 64,
> - .max = 64,
> - .increment = 0
> - },
> - .digest_size = {
> - .min = 20,
> - .max = 20,
> - .increment = 0
> - },
> - .aad_size = { 0 }
> - }, }
> - }, }
> - },
> - { /* SHA224 HMAC */
> - .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> - {.sym = {
> - .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
> - {.auth = {
> - .algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
> - .block_size = 64,
> - .key_size = {
Remove one tab before .key_size, to be aligned with the other fields.
Thanks,
Pablo
next prev parent reply other threads:[~2017-03-30 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 13:04 [dpdk-dev] [PATCH v2 0/3] Add ZUC EEA3/EIA3 capability to Intel(R) QuickAssist Technology driver Arek Kusztal
2017-03-29 13:04 ` [dpdk-dev] [PATCH v2 1/3] crypto/qat: refactor capabilities infrastructure Arek Kusztal
2017-03-30 13:34 ` Trahe, Fiona
2017-03-30 21:50 ` De Lara Guarch, Pablo [this message]
2017-03-29 13:04 ` [dpdk-dev] [PATCH v2 2/3] crypto/qat: add ZUC EEA3/EIA3 capability Arek Kusztal
2017-03-30 13:35 ` Trahe, Fiona
2017-03-29 13:04 ` [dpdk-dev] [PATCH v2 3/3] test: add ZUC test cases for QAT Arek Kusztal
2017-03-30 13:36 ` Trahe, Fiona
2017-03-30 21:29 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D89747712AFD@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).