From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 88459326C for ; Thu, 30 Mar 2017 23:50:49 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 30 Mar 2017 14:50:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,248,1486454400"; d="scan'208";a="82881746" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2017 14:50:47 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Mar 2017 22:50:47 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by IRSMSX156.ger.corp.intel.com ([169.254.3.246]) with mapi id 14.03.0319.002; Thu, 30 Mar 2017 22:50:46 +0100 From: "De Lara Guarch, Pablo" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "Trahe, Fiona" , "Griffin, John" , "Jain, Deepak K" Thread-Topic: [PATCH v2 1/3] crypto/qat: refactor capabilities infrastructure Thread-Index: AQHSqI0G0PMaymPrWk2dIJm2KfBg76Gt7b0A Date: Thu, 30 Mar 2017 21:50:46 +0000 Message-ID: References: <1490792659-31544-1-git-send-email-arkadiuszx.kusztal@intel.com> <1490792659-31544-2-git-send-email-arkadiuszx.kusztal@intel.com> In-Reply-To: <1490792659-31544-2-git-send-email-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTI1OTNiMjktMmI3OC00MTg0LTk5ZTEtZjgxZmE0ZWQ3YTdjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjlRODNFV0Y1SUN3amtySk9nMVdnZVZja01jUlhOVkZ4NVJ3dUxRUDUyaVE9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] crypto/qat: refactor capabilities infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 21:50:50 -0000 > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, March 29, 2017 2:04 PM > To: dev@dpdk.org > Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K; > Kusztal, ArkadiuszX > Subject: [PATCH v2 1/3] crypto/qat: refactor capabilities infrastructure >=20 > Refactor capabilities data structures to facilitate > defining different capability sets for different devices > without duplication of data. >=20 > Signed-off-by: Arek Kusztal > --- > drivers/crypto/qat/qat_crypto.c | 532 ++-------------------= ------ > drivers/crypto/qat/qat_crypto.h | 3 + > drivers/crypto/qat/qat_crypto_capabilities.h | 510 > +++++++++++++++++++++++++ > drivers/crypto/qat/rte_qat_cryptodev.c | 24 ++ > 4 files changed, 577 insertions(+), 492 deletions(-) > create mode 100644 drivers/crypto/qat/qat_crypto_capabilities.h >=20 > diff --git a/drivers/crypto/qat/qat_crypto.c > b/drivers/crypto/qat/qat_crypto.c > index 9310211..9678a70 100644 > --- a/drivers/crypto/qat/qat_crypto.c > +++ b/drivers/crypto/qat/qat_crypto.c > @@ -69,497 +69,45 @@ >=20 > #define BYTE_LENGTH 8 >=20 > -static const struct rte_cryptodev_capabilities qat_pmd_capabilities[] = =3D { > - { /* SHA1 HMAC */ > - .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, > - {.sym =3D { > - .xform_type =3D RTE_CRYPTO_SYM_XFORM_AUTH, > - {.auth =3D { > - .algo =3D RTE_CRYPTO_AUTH_SHA1_HMAC, > - .block_size =3D 64, > - .key_size =3D { > - .min =3D 64, > - .max =3D 64, > - .increment =3D 0 > - }, > - .digest_size =3D { > - .min =3D 20, > - .max =3D 20, > - .increment =3D 0 > - }, > - .aad_size =3D { 0 } > - }, } > - }, } > - }, > - { /* SHA224 HMAC */ > - .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, > - {.sym =3D { > - .xform_type =3D RTE_CRYPTO_SYM_XFORM_AUTH, > - {.auth =3D { > - .algo =3D RTE_CRYPTO_AUTH_SHA224_HMAC, > - .block_size =3D 64, > - .key_size =3D { Remove one tab before .key_size, to be aligned with the other fields. Thanks, Pablo