From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 435162E8A for ; Wed, 12 Apr 2017 11:26:21 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2017 02:26:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,189,1488873600"; d="scan'208";a="1118528569" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga001.jf.intel.com with ESMTP; 12 Apr 2017 02:26:18 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 12 Apr 2017 10:26:18 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by irsmsx111.ger.corp.intel.com ([169.254.2.58]) with mapi id 14.03.0319.002; Wed, 12 Apr 2017 10:26:17 +0100 From: "De Lara Guarch, Pablo" To: Olivier Matz , "dev@dpdk.org" CC: "david.marchand@6wind.com" , "Richardson, Bruce" , "thomas.monjalon@6wind.com" , "Wiles, Keith" , "stephen@networkplumber.org" Thread-Topic: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs Thread-Index: AQHSrWLYCYBKRhKbW0CJ5n09VnxKCaHBgIkw Date: Wed, 12 Apr 2017 09:26:16 +0000 Message-ID: References: <20170329155323.4760-1-olivier.matz@6wind.com> <20170404164040.24132-1-olivier.matz@6wind.com> In-Reply-To: <20170404164040.24132-1-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTBjYTU1NDAtZGE3OS00YmFmLWI3MWEtZTM5YzdlMTc0MGVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjJtR2FLSXJQZXFrXC9FcEd6eUswU1dyM1Mrcm1oSGhOcXFxWUV2WUpwT0xZPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 09:26:21 -0000 Hi Olivier, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz > Sent: Tuesday, April 04, 2017 5:41 PM > To: dev@dpdk.org > Cc: david.marchand@6wind.com; Richardson, Bruce; > thomas.monjalon@6wind.com; Wiles, Keith; > stephen@networkplumber.org > Subject: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs >=20 > The objective of this patchset is to introduce a framework to > support dynamic log types in EAL. It also provides one example of use > (in i40e). >=20 > Features: > - log types are identified by a string > - at registration, a uniq identifier is associated to a log type > - each log type can have its level changed dynamically > - extend command line parameters to set the log level of a specific > type, or logs matching a regular expression > - keep compat with other legacy types (eal, malloc, ring, user*, > etc... keep their hardcoded log type value) >=20 > Next step is to adapt drivers, libs and apps to use this new API. At the > end, we can expect that all non-dataplane logs are moved to be dynamic, > so we can enable/disable them at runtime, without recompiling. Many > debug options can probably be removed from configuration: > $ git grep DEBUG config/common_base | wc -l > 89 >=20 > v2 -> v3: > - fix compilation of intermediate patches > - replace references to 17.02 by 17.05 (doc and .map) >=20 > v1 -> v2: > - fix issues reported by Stephen > - add entry in release note and deprecation notice > - rebase on top of master >=20 > RFC -> v1: > - rebase on top of current master > - fix eal help alignment > - remove unused i40e compilation options >=20 >=20 With this patch, all logs that use logtype "USERX" (e.g. RTE_LOGTYPE_USER1= ) are not shown anymore. Should these macro be removed? Right now, all applications using this won't show these, so I assume that a= ll of them should be fixed before the release is out. Is that correct? Thanks, Pablo