From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id DDD0F377E for ; Tue, 2 May 2017 15:12:00 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2017 06:11:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,405,1488873600"; d="scan'208";a="963448470" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga003.jf.intel.com with ESMTP; 02 May 2017 06:11:54 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 2 May 2017 14:11:53 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by irsmsx155.ger.corp.intel.com ([169.254.14.202]) with mapi id 14.03.0319.002; Tue, 2 May 2017 14:11:53 +0100 From: "De Lara Guarch, Pablo" To: "Pattan, Reshma" CC: "dev@dpdk.org" , "Wu, Jingjing" Thread-Topic: [PATCH] app/testpmd: disable latency stats by default Thread-Index: AQHSw0WQTnV6TOAV0EuN2Fkw+C3xZ6HhBKXQ Date: Tue, 2 May 2017 13:11:52 +0000 Message-ID: References: <1493730674-102633-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1493730674-102633-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTNkODU5ZGQtZjNjMC00NWRhLWI5YzgtY2YyMTE4NGE4NDRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlFkM1ZlV2tpSWVWNWhJYVNnODB2OEZZUXk5cGtiTzBwelNQbzNwZmVhdGs9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: disable latency stats by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 13:12:01 -0000 CC'ing Jingjing. > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Tuesday, May 02, 2017 2:11 PM > To: jingjing@intel.com; Pattan, Reshma > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] app/testpmd: disable latency stats by default >=20 > Disable latency stats gathering by default, > so there is not performance degradation if user > is not interested in them. >=20 > Signed-off-by: Pablo de Lara > --- > app/test-pmd/testpmd.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index dfe6442..23dfdb0 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -971,7 +971,8 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc, > packet_fwd_t pkt_fwd) > } > #endif > #ifdef RTE_LIBRTE_LATENCY_STATS > - if (latencystats_lcore_id =3D=3D rte_lcore_id()) > + if (latencystats_enabled !=3D 0 && > + latencystats_lcore_id =3D=3D rte_lcore_id()) > rte_latencystats_update(); > #endif >=20 > @@ -2238,8 +2239,9 @@ main(int argc, char** argv) > rte_panic("Empty set of forwarding logical cores - check the > " > "core mask supplied in the command > parameters\n"); >=20 > - /* Bitrate stats disabled by default */ > + /* Bitrate/latency stats disabled by default */ > bitrate_enabled =3D 0; > + latencystats_enabled =3D 0; >=20 > argc -=3D diag; > argv +=3D diag; > -- > 2.7.4