From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 69F3F23B for ; Wed, 7 Jun 2017 15:13:43 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2017 06:13:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,311,1493708400"; d="scan'208";a="111491125" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga005.fm.intel.com with ESMTP; 07 Jun 2017 06:13:41 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX152.ger.corp.intel.com ([169.254.6.83]) with mapi id 14.03.0319.002; Wed, 7 Jun 2017 14:13:40 +0100 From: "De Lara Guarch, Pablo" To: "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [PATCH] app/testpmd: print statistics periodically Thread-Index: AQHS1/rEO/ScF2dZCE+8Jvg7b2E5DaIZG2cAgABURjA= Date: Wed, 7 Jun 2017 13:13:39 +0000 Message-ID: References: <1496007534-182470-1-git-send-email-pablo.de.lara.guarch@intel.com> <9BB6961774997848B5B42BEC655768F810D9CBDA@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D9CBDA@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjkyYjk0NmUtM2FkYy00ZWEwLWI2MTItZTdhMmNiNzBmNDk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikt6aUdrckZMMzVNcmJTS0FMcndUeGVsTGxCN1dcL05mXC94VUQ5dEhUVjlzRT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: print statistics periodically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 13:13:43 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Wednesday, June 07, 2017 10:12 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: RE: [PATCH] app/testpmd: print statistics periodically >=20 >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Monday, May 29, 2017 5:39 AM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > > Subject: [PATCH] app/testpmd: print statistics periodically > > > > Add parameter to print port statistics periodically > > (disabled by default), if interactive mode is not enabled. > > > > This is useful to allow the user to see port statistics > > without having to get into the internal command line. > > > > Signed-off-by: Pablo de Lara > > --- > > app/test-pmd/parameters.c | 15 ++++++++++++- > > app/test-pmd/testpmd.c | 40 > > ++++++++++++++++++++++++++++++++++- > > app/test-pmd/testpmd.h | 1 + > > doc/guides/testpmd_app_ug/run_app.rst | 5 +++++ > > 4 files changed, 59 insertions(+), 2 deletions(-) > > > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > > index fbe6284..a758b25 100644 > > --- a/app/test-pmd/parameters.c > > +++ b/app/test-pmd/parameters.c > > @@ -89,6 +89,7 @@ usage(char* progname) > > "[--cmdline-file=3DFILENAME] " > > #endif > > "[--help|-h] | [--auto-start|-a] | [" > > + "-T PERIOD: statistics will be shown every PERIOD seconds (onl= y > if interactive is > How about change it following format? >=20 > "[--help|-h] | [--auto-start|-a] | [ -T PERIOD] | [" > "-T PERIOD: statistics will be shown every PERIOD seconds (only if > interactive is > "--coremask=3DCOREMASK --portmask=3DPORTMASK --numa " >=20 >=20 > Add line after printf(" --help: ...... > printf("-T PERIOD: statistics will be shown every PERIOD seconds (only if > interactive is disabled)\n"); >=20 Agreed. Will change this, thanks for the review. Pablo