From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 33A8A2BB8 for ; Wed, 7 Jun 2017 15:20:48 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2017 06:20:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,311,1493708400"; d="scan'208";a="271297162" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga004.fm.intel.com with ESMTP; 07 Jun 2017 06:20:47 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Jun 2017 14:20:46 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by irsmsx155.ger.corp.intel.com ([169.254.14.182]) with mapi id 14.03.0319.002; Wed, 7 Jun 2017 14:20:46 +0100 From: "De Lara Guarch, Pablo" To: "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [PATCH] app/testpmd: add parameter to start forwarding sending Thread-Index: AQHS1/pvzdLCvEMT8kuWf5YjSbAiGaIZHRGAgABTABA= Date: Wed, 7 Jun 2017 13:20:45 +0000 Message-ID: References: <1496007391-182136-1-git-send-email-pablo.de.lara.guarch@intel.com> <9BB6961774997848B5B42BEC655768F810D9CBF6@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D9CBF6@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTQ3NDdlOGYtZGQwYy00YTgzLTljYmUtYjcyNWRhN2U3ZGUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlpCVTJCVDR1QkpJVnF5XC9hRlJadVZ4bmc4V2liaGp4SG9sS1ZaOXdvQ0hNPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add parameter to start forwarding sending X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 13:20:49 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Wednesday, June 07, 2017 10:18 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: RE: [PATCH] app/testpmd: add parameter to start forwarding > sending >=20 >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Monday, May 29, 2017 5:37 AM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > > Subject: [PATCH] app/testpmd: add parameter to start forwarding > sending > > > > Add parameter to start forwarding sending first > > a burst of packets, which is useful when testing > > a loopback connection. > > > > This was already implemented as an internal command, > > but adding it as a parameter is interesting, as it > > allows the user to test a loopback connection without > > entering in the internal command line. > > > > Signed-off-by: Pablo de Lara > > --- > > app/test-pmd/parameters.c | 5 +++++ > > app/test-pmd/testpmd.c | 5 +++-- > > app/test-pmd/testpmd.h | 1 + > > doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ > > 4 files changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > > index fbe6284..0da4172 100644 > > --- a/app/test-pmd/parameters.c > > +++ b/app/test-pmd/parameters.c > > @@ -89,6 +89,7 @@ usage(char* progname) > > "[--cmdline-file=3DFILENAME] " > > #endif > > "[--help|-h] | [--auto-start|-a] | [" > > + "--tx-first" >=20 > Just consider about the interactive mode. > If using command start, will it still call start_packet_forwarding(0)? > And if start tx_first, still call start_packet_forwarding(1)? >=20 If using the commands "start" and "start tx_first", the behaviour will rema= in the same. The only behaviour that will change is the non-interactive forwarding mode, and when using auto-start in interactive mode. Do you think it should modify the behaviour of "start", in the command line= , so if "--tx-first" is passed, then it sends a burst regardless using "start= " or "start tx_first"? Thanks for the review! Pablo > It may cause confused whether this argu "--tx-first" works. > If it only works for non-interactive, you'd better to comment it. >=20 >=20 > Thanks > Jingjing