From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 6ECB72BB8
 for <dev@dpdk.org>; Thu,  8 Jun 2017 17:58:21 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 08 Jun 2017 08:58:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,315,1493708400"; d="scan'208";a="97145062"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by orsmga002.jf.intel.com with ESMTP; 08 Jun 2017 08:58:19 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.9]) with mapi id 14.03.0319.002;
 Thu, 8 Jun 2017 16:58:18 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= <gaetan.rivet@6wind.com>
CC: "Doherty, Declan" <declan.doherty@intel.com>, "thomas@monjalon.net"
 <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver
Thread-Index: AQHS1KI2a52WEOq0CU6LlGYqKgVmMqIaCBCAgAEuN/A=
Date: Thu, 8 Jun 2017 15:58:16 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBC067C@IRSMSX108.ger.corp.intel.com>
References: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <20170607225441.GX18840@bidouze.vm.6wind.com>
In-Reply-To: <20170607225441.GX18840@bidouze.vm.6wind.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWJlMGM3MDEtNTY0Yi00MWY0LThjZTUtNTkzZDA3ZDc2ZjNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRmR2R2a3Jqajd5dXdpNDlKdzZpQ0hmV3JxMzhWNGF4djFIZFFXUGNsS3c9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jun 2017 15:58:22 -0000

Hi Gaetan,

> -----Original Message-----
> From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Wednesday, June 07, 2017 11:55 PM
> To: De Lara Guarch, Pablo
> Cc: Doherty, Declan; thomas@monjalon.net; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver
>=20
> Hi Pablo,
>=20
> On Wed, May 24, 2017 at 04:27:02PM +0100, Pablo de Lara wrote:
> > Following the same aproach taken for ethdev, this patch series
> > removes the PCI specific structure cryptodev driver from rte_cryptodev.
> >
> > The patchset makes the following changes:
> >
> > - Moves the virtual and PCI device specific functions to separate files=
,
> >   so other cryptodev header files contain only device type agnostic
> functions.
> >
> > - Modifies device info retrieval function to set the driver name for al=
l
> devices
> >   and set PCI info inside PCI device PMDs
> >
> > - Removes cryptodev driver structure from cryptodev library and drivers
> >   that were using it (QAT and dpaa2)
> >
>=20
> While most of the work seems to be done within this patchset, there are
> still rte_pci.h includes in both:
>=20
> lib/librte_cryptodev/rte_cryptodev.c:50:#include <rte_pci.h>
> lib/librte_cryptodev/rte_cryptodev_pmd.h:50:#include <rte_pci.h>
>=20
> This breaks the compilation when the PCI bus is compiled outside the EAL.
> Would you be able to remove those last dependencies?

These includes have been removed already in the patchset.
Have you applied all 12 patches?

Thanks,
Pablo