From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 00D7C2BB8 for ; Fri, 9 Jun 2017 12:02:01 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2017 03:02:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,317,1493708400"; d="scan'208";a="978734836" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga003.jf.intel.com with ESMTP; 09 Jun 2017 03:01:59 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX106.ger.corp.intel.com ([169.254.8.236]) with mapi id 14.03.0319.002; Fri, 9 Jun 2017 11:01:59 +0100 From: "De Lara Guarch, Pablo" To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: "Doherty, Declan" , "thomas@monjalon.net" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver Thread-Index: AQHS1KI2a52WEOq0CU6LlGYqKgVmMqIaCBCAgAEuN/CAAR2TAIAAEZRQ Date: Fri, 9 Jun 2017 10:01:58 +0000 Message-ID: References: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com> <20170607225441.GX18840@bidouze.vm.6wind.com> <20170609095828.GE29091@bidouze.vm.6wind.com> In-Reply-To: <20170609095828.GE29091@bidouze.vm.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjU4NTU0ZGMtMWQzZS00N2FiLTk3YWYtODg3NjcyMzhkMzkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkxEc0NpRWg2WSs3SVVWakM3YjN6cTd4S0w5U0hJajl0R0pwRW9pdkxHMGc9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 10:02:02 -0000 > -----Original Message----- > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Friday, June 09, 2017 10:58 AM > To: De Lara Guarch, Pablo > Cc: Doherty, Declan; thomas@monjalon.net; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver >=20 > On Thu, Jun 08, 2017 at 03:58:16PM +0000, De Lara Guarch, Pablo wrote: > > Hi Gaetan, > > > > > -----Original Message----- > > > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > > > Sent: Wednesday, June 07, 2017 11:55 PM > > > To: De Lara Guarch, Pablo > > > Cc: Doherty, Declan; thomas@monjalon.net; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver > > > > > > Hi Pablo, > > > > > > On Wed, May 24, 2017 at 04:27:02PM +0100, Pablo de Lara wrote: > > > > Following the same aproach taken for ethdev, this patch series > > > > removes the PCI specific structure cryptodev driver from > rte_cryptodev. > > > > > > > > The patchset makes the following changes: > > > > > > > > - Moves the virtual and PCI device specific functions to separate f= iles, > > > > so other cryptodev header files contain only device type agnostic > > > functions. > > > > > > > > - Modifies device info retrieval function to set the driver name fo= r all > > > devices > > > > and set PCI info inside PCI device PMDs > > > > > > > > - Removes cryptodev driver structure from cryptodev library and > drivers > > > > that were using it (QAT and dpaa2) > > > > > > > > > > While most of the work seems to be done within this patchset, there > are > > > still rte_pci.h includes in both: > > > > > > lib/librte_cryptodev/rte_cryptodev.c:50:#include > > > lib/librte_cryptodev/rte_cryptodev_pmd.h:50:#include > > > > > > This breaks the compilation when the PCI bus is compiled outside the > EAL. > > > Would you be able to remove those last dependencies? > > > > These includes have been removed already in the patchset. > > Have you applied all 12 patches? > > >=20 > Ah yes, sorry, I must have missed a few. > I have some trouble applying the patch however, I will test the > integration with the PCI bus move after I resolve this. It might not apply cleanly after the latest patches that got merged. I will send a rebased v2. Pablo >=20 > > Thanks, > > Pablo > > > > >=20 > -- > Ga=EBtan Rivet > 6WIND