From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pablo.de.lara.guarch@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5FF20271 for <dev@dpdk.org>; Wed, 28 Jun 2017 00:22:38 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2017 15:22:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,272,1496127600"; d="scan'208";a="1165341080" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 27 Jun 2017 15:22:35 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX152.ger.corp.intel.com ([169.254.6.83]) with mapi id 14.03.0319.002; Tue, 27 Jun 2017 23:22:35 +0100 From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "Doherty, Declan" <declan.doherty@intel.com> Thread-Topic: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file Thread-Index: AQHS6pqkZHbD3jElJEKLp+w7R8f7KqIyWUqAgAVpRYCAALflYIAAQtIAgAAL7gCAABA5gIAAIiYQgABWB0A= Date: Tue, 27 Jun 2017 22:22:34 +0000 Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBCDD69@IRSMSX108.ger.corp.intel.com> References: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com> <1703981.y8KKVdfaY4@xps> <8d33a2ad-b80c-1337-0db3-88aa5e6fcb07@intel.com> <1580410.hOtKtBbxIg@xps> <E115CCD9D858EF4F90C690B0DCB4D8976CBCD95D@IRSMSX108.ger.corp.intel.com> In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CBCD95D@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 27 Jun 2017 22:22:39 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, June 27, 2017 6:12 PM > To: Thomas Monjalon <thomas@monjalon.net>; Yigit, Ferruh > <ferruh.yigit@intel.com> > Cc: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions > to a separate file >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Tuesday, June 27, 2017 5:09 PM > > To: Yigit, Ferruh <ferruh.yigit@intel.com> > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > <pablo.de.lara.guarch@intel.com>; Doherty, Declan > > <declan.doherty@intel.com> > > Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev > > functions to a separate file > > > > 27/06/2017 17:11, Ferruh Yigit: > > > On 6/27/2017 3:28 PM, Thomas Monjalon wrote: > > > > 27/06/2017 11:51, De Lara Guarch, Pablo: > > > >> From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > >>> 23/06/2017 14:52, Declan Doherty: > > > >>>> On 21/06/2017 7:28 AM, Pablo de Lara wrote: > > > >>>>> Move all functions handling virtual devices to a separate > > > >>>>> header file "rte_cryptodev_vdev.h", in order to leave only > > > >>>>> generic functions for any device in the rest of the files. > > > >>>>> > > > >>>>> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > > > >>>> > > > >>>> Acked-by: Declan Doherty <declan.doherty@intel.com> > > > >>> > > > >>> This patch is moving some code from a .c to a .h. > > > >>> The consequence is that driver are now compiling new functions > > > >>> from the .h and require librte_kvargs to link with. > > > >>> It is a build error in shared lib mode. > > > >>> > > > >>> Please keep the code in a .c file if possible. > > > >> > > > >> Sorry about this. I just fixed it in the subtree, so pull it > > > >> whenever you > > are ready. > > > >> Also, since ethdev have separated pci and vdev functions in > > > >> separate .h files, I preferred to be consistent and do the same. > > > > > > > > There is no reason to implement these functions in .h files. > > > > I prefer to keep them in a .c file and just export the proto in .h. > > > > > > This is same in the eth_dev too. > > > > > > These are helper functions, and implementing them in .h file has the > > > benefit of function goes into PMD library, and there is no > > > dependency from PMDs to librte_ether for these functions (there are > > > dependencies for other functions ..). > > > > > > It looks acceptable for me for helper functions to be implemented in > > > header file. But if we decide to move them into .c file, .map file > > > should be updated to export them, and I suppose ethdev also should > > > be updated to be compatible. > > > > Yes we should avoid adding code in .h. > > It is accepted only for performance reasons. > > ethdev can be reworked later. > > cryptodev can be improved now and avoid adding rte_devargs deps on > > PMDs. >=20 > Ok, will make those changes shortly. I have implemented these functions in a separated .c file and pushed it to = dpdk-next-crypto. Pablo >=20 > Pablo