From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4457E2B99 for ; Mon, 3 Jul 2017 01:43:10 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 02 Jul 2017 16:43:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,300,1496127600"; d="scan'208";a="1167351927" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga001.fm.intel.com with ESMTP; 02 Jul 2017 16:43:09 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX107.ger.corp.intel.com ([169.254.10.129]) with mapi id 14.03.0319.002; Mon, 3 Jul 2017 00:43:08 +0100 From: "De Lara Guarch, Pablo" To: "akhil.goyal@nxp.com" , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" , "Doherty, Declan" Thread-Topic: [PATCH 0/5] crypto/dpaa2_sec optimization and feature update Thread-Index: AQHS8Rld4oN2EZclA0SQzP7LSZGR/6JBNmiw Date: Sun, 2 Jul 2017 23:43:08 +0000 Message-ID: References: <20170629204904.23684-1-akhil.goyal@nxp.com> In-Reply-To: <20170629204904.23684-1-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/5] crypto/dpaa2_sec optimization and feature update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jul 2017 23:43:11 -0000 > -----Original Message----- > From: akhil.goyal@nxp.com [mailto:akhil.goyal@nxp.com] > Sent: Thursday, June 29, 2017 9:49 PM > To: dev@dpdk.org > Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo > ; Doherty, Declan > ; Akhil Goyal > Subject: [PATCH 0/5] crypto/dpaa2_sec optimization and feature update >=20 > From: Akhil Goyal >=20 > This patchset updates dpaa2_sec crypto driver with following: > - optimization in data path for memory allocation > - add support for additional AES algorithms like AES-GCM and AES-CTR > - Update test cases in test_cryptodev for all the supported test cases. > - Update documentation for supported algorithms >=20 > The patches are based on dpdk-crypto-next and are rebased over the latest > crypto restructuring changes by Pablo. > http://dpdk.org/ml/archives/dev/2017-June/069372.html >=20 >=20 > Akhil Goyal (5): > crypto/dpaa2_sec: add per device mempool to store frame list entries > crypto/dpaa2_sec: add descriptor support for gcm and ctr > crypto/dpaa2_sec: add support for AES-GCM and CTR > test/test: add test cases for gcm and ctr in dpaa2_sec test suite > doc: update documentation for dpaa2_sec supported algos >=20 > doc/guides/cryptodevs/dpaa2_sec.rst | 9 +- > doc/guides/cryptodevs/features/dpaa2_sec.ini | 6 + > drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 7 + > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 384 > ++++++++++++++++++++++++--- > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 100 ++++--- > drivers/crypto/dpaa2_sec/hw/desc/algo.h | 226 +++++++++++++++- > drivers/crypto/dpaa2_sec/hw/desc/ipsec.h | 19 +- > test/test/test_cryptodev.c | 94 ++++++- > test/test/test_cryptodev_aes_test_vectors.h | 78 ++++-- > test/test/test_cryptodev_blockcipher.c | 1 + > test/test/test_cryptodev_des_test_vectors.h | 24 +- > test/test/test_cryptodev_hash_test_vectors.h | 36 ++- > 12 files changed, 846 insertions(+), 138 deletions(-) >=20 > -- > 2.9.3 Hi Akhil, There are some issues with check-git-log.sh on your patches. Wrong headline format: test/test: add test cases for gcm and ctr in dpaa2_sec test suite Wrong headline prefix: crypto/dpaa2_sec: add per device mempool to store frame list entrie= s Wrong headline lowercase: crypto/dpaa2_sec: add hw desc support for CTR crypto/dpaa2_sec: add hw desc support for AES-GCM Headline too long: crypto/dpaa2_sec: add per device mempool to store frame list entrie= s test/test: add test cases for gcm and ctr in dpaa2_sec test suite For the first patch, change from "test/test: ...." to "test/crypto..." too. Also, you can probably merge the last two patches, as you are adding existi= ng tests to the dpaa2 testsuite, for the changes made in patch 4. Lastly, I submitted a v4 for the crypto rework, so make sure you rebase on = top of this patchset before sending a v2. Thanks! Pablo