From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/4] crypto/aesni_gcm: migrate to Multi-buffer library
Date: Tue, 4 Jul 2017 10:17:42 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBD5205@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <41165408-0b98-7357-6c0c-339eedddc4a9@intel.com>
> -----Original Message-----
> From: Doherty, Declan
> Sent: Tuesday, July 4, 2017 10:43 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Gonzalez Monroy, Sergio
> <sergio.gonzalez.monroy@intel.com>
> Subject: Re: [PATCH v3 1/4] crypto/aesni_gcm: migrate to Multi-buffer
> library
>
> On 04/07/17 01:12, Pablo de Lara wrote:
> > Since Intel Multi Buffer library for IPSec has been updated to support
> > Scatter Gather List, the AESNI GCM PMD can link to this library,
> > instead of the ISA-L library.
> >
> > This move eases the maintenance of the driver, as it will use the same
> > library as the AESNI MB PMD.
> > It also adds support for 192-bit keys.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > Signed-off-by: Sergio Gonzalez Monroy
> > <sergio.gonzalez.monroy@intel.com>
> > ---
> > devtools/test-build.sh | 4 +-
> > doc/guides/cryptodevs/aesni_gcm.rst | 53 ++++++++---
> > doc/guides/cryptodevs/features/aesni_gcm.ini | 4 +-
> > doc/guides/rel_notes/release_17_08.rst | 8 ++
> > drivers/crypto/aesni_gcm/Makefile | 9 +-
> > drivers/crypto/aesni_gcm/aesni_gcm_ops.h | 97
> ++++++++++++++++++--
> > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 111
> +++++++++++++----------
> > drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 14 ++-
> > drivers/crypto/aesni_gcm/aesni_gcm_pmd_private.h | 28 +++---
> > mk/rte.app.mk | 3 +-
> > 10 files changed, 238 insertions(+), 93 deletions(-)
> >
> > diff --git a/devtools/test-build.sh b/devtools/test-build.sh index
> > 079c8b8..c6dfaf0 100755
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -38,7 +38,6 @@ default_path=$PATH
> > # - DPDK_BUILD_TEST_CONFIGS (defconfig1+option1+option2
> defconfig2)
> > # - DPDK_DEP_ARCHIVE
> > # - DPDK_DEP_CFLAGS
> > -# - DPDK_DEP_ISAL_CRYPTO (y/[n])
> > # - DPDK_DEP_LDFLAGS
> > # - DPDK_DEP_MOFED (y/[n])
> > # - DPDK_DEP_NUMA ([y]/n)
> > @@ -121,7 +120,6 @@ reset_env ()
> > unset CROSS
> > unset DPDK_DEP_ARCHIVE
> > unset DPDK_DEP_CFLAGS
> > - unset DPDK_DEP_ISAL_CRYPTO
> > unset DPDK_DEP_LDFLAGS
> > unset DPDK_DEP_MOFED
> > unset DPDK_DEP_NUMA
> > @@ -182,7 +180,7 @@ config () # <directory> <target> <options>
> > sed -ri 's,(PMD_ARMV8_CRYPTO=)n,\1y,' $1/.config
> > test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \
> > sed -ri 's,(PMD_AESNI_MB=)n,\1y,' $1/.config
> > - test "$DPDK_DEP_ISAL_CRYPTO" != y || \
> > + test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \
> > sed -ri 's,(PMD_AESNI_GCM=)n,\1y,' $1/.config
> > test -z "$LIBSSO_SNOW3G_PATH" || \
> > sed -ri 's,(PMD_SNOW3G=)n,\1y,' $1/.config
> > diff --git a/doc/guides/cryptodevs/aesni_gcm.rst
> > b/doc/guides/cryptodevs/aesni_gcm.rst
> > index 84cdc52..591c0b1 100644
> > --- a/doc/guides/cryptodevs/aesni_gcm.rst
> > +++ b/doc/guides/cryptodevs/aesni_gcm.rst
> > @@ -1,5 +1,5 @@
> > .. BSD LICENSE
> > - Copyright(c) 2016 Intel Corporation. All rights reserved.
> > + Copyright(c) 2016-2017 Intel Corporation. All rights reserved.
> >
> > Redistribution and use in source and binary forms, with or without
> > modification, are permitted provided that the following
> > conditions @@ -32,8 +32,8 @@ AES-NI GCM Crypto Poll Mode Driver
> >
> >
> > The AES-NI GCM PMD (**librte_pmd_aesni_gcm**) provides poll mode
> > crypto driver -support for utilizing Intel ISA-L crypto library, which
> > provides operation acceleration -through the AES-NI instruction sets for
> AES-GCM authenticated cipher algorithm.
> > +support for utilizing Intel multi buffer library (see AES-NI
> > +Multi-buffer PMD documentation to learn more about it, including
> installation).
> >
> > Features
> > --------
> > @@ -49,19 +49,51 @@ Authentication algorithms:
> > * RTE_CRYPTO_AUTH_AES_GCM
> > * RTE_CRYPTO_AUTH_AES_GMAC
> >
>
> AES GCM should be listed under AEAD algorithms now
>
> > +Limitations
> > +-----------
> >
>
> Acked-by: Declan Doherty <declan.doherty@intel.com>
>
Hi,
Will fix the documentation when merging the patch.
Thanks for the review!
Pablo
next prev parent reply other threads:[~2017-07-04 10:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 10:16 [dpdk-dev] [PATCH 0/2] AESNI GCM PMD: Migration from ISA-L " Pablo de Lara
2017-05-26 10:16 ` [dpdk-dev] [PATCH 1/2] crypto/aesni_gcm: migrate " Pablo de Lara
2017-05-26 10:16 ` [dpdk-dev] [PATCH 2/2] test/crypto: add AES GCM 192 tests Pablo de Lara
2017-06-28 11:32 ` [dpdk-dev] [PATCH v2 0/4] AESNI GCM PMD: Migration from ISA-L to Multi-buffer library Pablo de Lara
2017-06-28 11:32 ` [dpdk-dev] [PATCH v2 1/4] crypto/aesni_gcm: migrate " Pablo de Lara
2017-06-28 11:32 ` [dpdk-dev] [PATCH v2 2/4] test/crypto: rename some tests Pablo de Lara
2017-06-28 11:32 ` [dpdk-dev] [PATCH v2 3/4] test/crypto: add AES GCM 192 tests Pablo de Lara
2017-06-28 11:32 ` [dpdk-dev] [PATCH v2 4/4] test/crypto: extend AES-GCM 192/256 to other PMDs Pablo de Lara
2017-06-30 14:16 ` [dpdk-dev] [PATCH v2 0/4] AESNI GCM PMD: Migration from ISA-L to Multi-buffer library Sergio Gonzalez Monroy
2017-07-04 10:11 ` De Lara Guarch, Pablo
2017-07-04 0:12 ` [dpdk-dev] [PATCH v3 " Pablo de Lara
2017-07-04 0:12 ` [dpdk-dev] [PATCH v3 1/4] crypto/aesni_gcm: migrate " Pablo de Lara
2017-07-04 9:43 ` Declan Doherty
2017-07-04 10:17 ` De Lara Guarch, Pablo [this message]
2017-07-04 0:12 ` [dpdk-dev] [PATCH v3 2/4] test/crypto: rename some tests Pablo de Lara
2017-07-04 0:12 ` [dpdk-dev] [PATCH v3 3/4] test/crypto: add AES GCM 192 tests Pablo de Lara
2017-07-04 0:12 ` [dpdk-dev] [PATCH v3 4/4] test/crypto: extend AES-GCM 192/256 to other PMDs Pablo de Lara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBD5205@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).