From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 53ED62C8 for ; Thu, 6 Jul 2017 09:49:35 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2017 00:49:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,316,1496127600"; d="scan'208";a="989316568" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga003.jf.intel.com with ESMTP; 06 Jul 2017 00:49:33 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX107.ger.corp.intel.com ([169.254.10.129]) with mapi id 14.03.0319.002; Thu, 6 Jul 2017 08:49:32 +0100 From: "De Lara Guarch, Pablo" To: 'Akhil Goyal' , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" Thread-Topic: [PATCH] crypto/dpaa2_sec: update driver name string Thread-Index: AQHS9asBsUSsG+TC50y+9JiNi3tHJKJFbQbQ Date: Thu, 6 Jul 2017 07:49:31 +0000 Message-ID: References: <20170705162142.11170-1-akhil.goyal@nxp.com> In-Reply-To: <20170705162142.11170-1-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: update driver name string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 07:49:36 -0000 Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Wednesday, July 5, 2017 5:22 PM > To: dev@dpdk.org > Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo > ; Akhil Goyal > Subject: [PATCH] crypto/dpaa2_sec: update driver name string >=20 > while registering driver to dpaa2, hard coded string is used. > It is now updated as per the latest changes in string name. >=20 > Signed-off-by: Akhil Goyal > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 769a139..b0794f5 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -2008,5 +2008,5 @@ static struct rte_dpaa2_driver > rte_dpaa2_sec_driver =3D { > .remove =3D cryptodev_dpaa2_sec_remove, > }; >=20 > -RTE_PMD_REGISTER_DPAA2(dpaa2_sec_pmd, rte_dpaa2_sec_driver); > +RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD, > rte_dpaa2_sec_driver); > RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver, > cryptodev_driver_id); > -- > 2.9.3 Now that the name is internal, and since this not used to create a vdev and= therefore, it is not used publicly, could we modify the name from "crypto_dpaa2_sec_pm= d" to "crypto_dpaa2_sec", to follow the crypto driver name convention (crypto_? Thanks, Pablo