* [dpdk-dev] [PATCH] crypto/dpaa2_sec: update driver name string
@ 2017-07-05 16:21 Akhil Goyal
2017-07-06 7:49 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 5+ messages in thread
From: Akhil Goyal @ 2017-07-05 16:21 UTC (permalink / raw)
To: dev; +Cc: hemant.agrawal, pablo.de.lara.guarch, Akhil Goyal
while registering driver to dpaa2, hard coded string is used.
It is now updated as per the latest changes in string name.
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 769a139..b0794f5 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -2008,5 +2008,5 @@ static struct rte_dpaa2_driver rte_dpaa2_sec_driver = {
.remove = cryptodev_dpaa2_sec_remove,
};
-RTE_PMD_REGISTER_DPAA2(dpaa2_sec_pmd, rte_dpaa2_sec_driver);
+RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD, rte_dpaa2_sec_driver);
RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver, cryptodev_driver_id);
--
2.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: update driver name string
2017-07-05 16:21 [dpdk-dev] [PATCH] crypto/dpaa2_sec: update driver name string Akhil Goyal
@ 2017-07-06 7:49 ` De Lara Guarch, Pablo
2017-07-06 8:54 ` Akhil Goyal
0 siblings, 1 reply; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2017-07-06 7:49 UTC (permalink / raw)
To: 'Akhil Goyal', dev; +Cc: hemant.agrawal
Hi Akhil,
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, July 5, 2017 5:22 PM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH] crypto/dpaa2_sec: update driver name string
>
> while registering driver to dpaa2, hard coded string is used.
> It is now updated as per the latest changes in string name.
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> index 769a139..b0794f5 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> @@ -2008,5 +2008,5 @@ static struct rte_dpaa2_driver
> rte_dpaa2_sec_driver = {
> .remove = cryptodev_dpaa2_sec_remove,
> };
>
> -RTE_PMD_REGISTER_DPAA2(dpaa2_sec_pmd, rte_dpaa2_sec_driver);
> +RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD,
> rte_dpaa2_sec_driver);
> RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver,
> cryptodev_driver_id);
> --
> 2.9.3
Now that the name is internal, and since this not used to create a vdev and therefore,
it is not used publicly, could we modify the name from "crypto_dpaa2_sec_pmd" to
"crypto_dpaa2_sec", to follow the crypto driver name convention (crypto_<pmd_name>?
Thanks,
Pablo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: update driver name string
2017-07-06 7:49 ` De Lara Guarch, Pablo
@ 2017-07-06 8:54 ` Akhil Goyal
2017-07-06 8:56 ` De Lara Guarch, Pablo
2017-07-06 11:00 ` De Lara Guarch, Pablo
0 siblings, 2 replies; 5+ messages in thread
From: Akhil Goyal @ 2017-07-06 8:54 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev; +Cc: hemant.agrawal
On 7/6/2017 1:19 PM, De Lara Guarch, Pablo wrote:
> Hi Akhil,
>
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>> Sent: Wednesday, July 5, 2017 5:22 PM
>> To: dev@dpdk.org
>> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
>> Subject: [PATCH] crypto/dpaa2_sec: update driver name string
>>
>> while registering driver to dpaa2, hard coded string is used.
>> It is now updated as per the latest changes in string name.
>>
>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>> ---
>> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
>> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
>> index 769a139..b0794f5 100644
>> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
>> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
>> @@ -2008,5 +2008,5 @@ static struct rte_dpaa2_driver
>> rte_dpaa2_sec_driver = {
>> .remove = cryptodev_dpaa2_sec_remove,
>> };
>>
>> -RTE_PMD_REGISTER_DPAA2(dpaa2_sec_pmd, rte_dpaa2_sec_driver);
>> +RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD,
>> rte_dpaa2_sec_driver);
>> RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver,
>> cryptodev_driver_id);
>> --
>> 2.9.3
>
> Now that the name is internal, and since this not used to create a vdev and therefore,
> it is not used publicly, could we modify the name from "crypto_dpaa2_sec_pmd" to
> "crypto_dpaa2_sec", to follow the crypto driver name convention (crypto_<pmd_name>?
>
> Thanks,
> Pablo
>
>
yes no issues.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: update driver name string
2017-07-06 8:54 ` Akhil Goyal
@ 2017-07-06 8:56 ` De Lara Guarch, Pablo
2017-07-06 11:00 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2017-07-06 8:56 UTC (permalink / raw)
To: Akhil Goyal, dev; +Cc: hemant.agrawal
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Thursday, July 6, 2017 9:54 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: hemant.agrawal@nxp.com
> Subject: Re: [PATCH] crypto/dpaa2_sec: update driver name string
>
> On 7/6/2017 1:19 PM, De Lara Guarch, Pablo wrote:
> > Hi Akhil,
> >
> >> -----Original Message-----
> >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> >> Sent: Wednesday, July 5, 2017 5:22 PM
> >> To: dev@dpdk.org
> >> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> >> <pablo.de.lara.guarch@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> >> Subject: [PATCH] crypto/dpaa2_sec: update driver name string
> >>
> >> while registering driver to dpaa2, hard coded string is used.
> >> It is now updated as per the latest changes in string name.
> >>
> >> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> >> ---
> >> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> index 769a139..b0794f5 100644
> >> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> @@ -2008,5 +2008,5 @@ static struct rte_dpaa2_driver
> >> rte_dpaa2_sec_driver = {
> >> .remove = cryptodev_dpaa2_sec_remove,
> >> };
> >>
> >> -RTE_PMD_REGISTER_DPAA2(dpaa2_sec_pmd, rte_dpaa2_sec_driver);
> >> +RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD,
> >> rte_dpaa2_sec_driver);
> >> RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver,
> >> cryptodev_driver_id);
> >> --
> >> 2.9.3
> >
> > Now that the name is internal, and since this not used to create a
> > vdev and therefore, it is not used publicly, could we modify the name
> > from "crypto_dpaa2_sec_pmd" to "crypto_dpaa2_sec", to follow the
> crypto driver name convention (crypto_<pmd_name>?
> >
> > Thanks,
> > Pablo
> >
> >
> yes no issues.
I can make that change for you when merging this patch.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: update driver name string
2017-07-06 8:54 ` Akhil Goyal
2017-07-06 8:56 ` De Lara Guarch, Pablo
@ 2017-07-06 11:00 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2017-07-06 11:00 UTC (permalink / raw)
To: Akhil Goyal, dev; +Cc: hemant.agrawal
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Thursday, July 6, 2017 9:54 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: hemant.agrawal@nxp.com
> Subject: Re: [PATCH] crypto/dpaa2_sec: update driver name string
>
> On 7/6/2017 1:19 PM, De Lara Guarch, Pablo wrote:
> > Hi Akhil,
> >
> >> -----Original Message-----
> >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> >> Sent: Wednesday, July 5, 2017 5:22 PM
> >> To: dev@dpdk.org
> >> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> >> <pablo.de.lara.guarch@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> >> Subject: [PATCH] crypto/dpaa2_sec: update driver name string
> >>
> >> while registering driver to dpaa2, hard coded string is used.
> >> It is now updated as per the latest changes in string name.
> >>
> >> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> >> ---
> >> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> index 769a139..b0794f5 100644
> >> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> >> @@ -2008,5 +2008,5 @@ static struct rte_dpaa2_driver
> >> rte_dpaa2_sec_driver = {
> >> .remove = cryptodev_dpaa2_sec_remove,
> >> };
> >>
> >> -RTE_PMD_REGISTER_DPAA2(dpaa2_sec_pmd, rte_dpaa2_sec_driver);
> >> +RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD,
> >> rte_dpaa2_sec_driver);
> >> RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver,
> >> cryptodev_driver_id);
> >> --
> >> 2.9.3
> >
> > Now that the name is internal, and since this not used to create a
> > vdev and therefore, it is not used publicly, could we modify the name
> > from "crypto_dpaa2_sec_pmd" to "crypto_dpaa2_sec", to follow the
> crypto driver name convention (crypto_<pmd_name>?
> >
> > Thanks,
> > Pablo
> >
> >
> yes no issues.
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-06 11:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-05 16:21 [dpdk-dev] [PATCH] crypto/dpaa2_sec: update driver name string Akhil Goyal
2017-07-06 7:49 ` De Lara Guarch, Pablo
2017-07-06 8:54 ` Akhil Goyal
2017-07-06 8:56 ` De Lara Guarch, Pablo
2017-07-06 11:00 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).