From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9DE87271 for ; Thu, 6 Jul 2017 12:43:36 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2017 03:43:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,316,1496127600"; d="scan'208";a="1191365346" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga002.fm.intel.com with ESMTP; 06 Jul 2017 03:43:34 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX107.ger.corp.intel.com ([169.254.10.129]) with mapi id 14.03.0319.002; Thu, 6 Jul 2017 11:43:19 +0100 From: "De Lara Guarch, Pablo" To: Jerin Jacob CC: "Wu, Jingjing" , "thomas@monjalon.net" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4] app/testpmd: print statistics periodically Thread-Index: AQHS9j2E1sEMnlY+NUi5rbTVCf1isqJGgfeAgAAaheA= Date: Thu, 6 Jul 2017 10:43:18 +0000 Message-ID: References: <20170615014817.12543-1-pablo.de.lara.guarch@intel.com> <20170706015205.74325-1-pablo.de.lara.guarch@intel.com> <20170706100657.GA4232@jerin> In-Reply-To: <20170706100657.GA4232@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: print statistics periodically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 10:43:37 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > Sent: Thursday, July 6, 2017 11:07 AM > To: De Lara Guarch, Pablo > Cc: Wu, Jingjing ; thomas@monjalon.net; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: print statistics > periodically >=20 > -----Original Message----- > > Date: Thu, 6 Jul 2017 02:52:05 +0100 > > From: Pablo de Lara > > To: jingjing.wu@intel.com, thomas@monjalon.net > > CC: dev@dpdk.org, Pablo de Lara > > Subject: [dpdk-dev] [PATCH v4] app/testpmd: print statistics > > periodically > > X-Mailer: git-send-email 2.9.4 > > > > Add parameter to print port statistics periodically (disabled by > > default), if interactive mode is not enabled. > > > > This is useful to allow the user to see port statistics without having > > to get into the internal command line. > > > > Signed-off-by: Pablo de Lara > > Acked-by: Jingjing Wu > > --- > > > > Changes in v4: > > > > - Removed CamelCase > > - Used generic rte_get_timer_cycles() function, instead > > of TSC API. > > > > Changes in v3: > > > > - Added missing "|" character in help > > > > Changes in v2: > > > > - Added extra argument in help > > > > app/test-pmd/parameters.c | 19 +++++++++++++++-- > > app/test-pmd/testpmd.c | 40 > ++++++++++++++++++++++++++++++++++- > > app/test-pmd/testpmd.h | 1 + > > doc/guides/testpmd_app_ug/run_app.rst | 5 +++++ > > 4 files changed, 62 insertions(+), 3 deletions(-) > > > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > > index fbe6284..41ed74c 100644 > > --- a/app/test-pmd/parameters.c > > +++ b/app/test-pmd/parameters.c > > @@ -88,7 +88,7 @@ usage(char* progname) > > "[--interactive|-i] " > > "[--cmdline-file=3DFILENAME] " > > #endif > > - "[--help|-h] | [--auto-start|-a] | [" > > + "[--help|-h] | [--auto-start|-a] | [-T PERIOD] | [" > > "--coremask=3DCOREMASK --portmask=3DPORTMASK --numa " > > "--mbuf-size=3D | --total-num-mbufs=3D | " > > "--nb-cores=3D | --nb-ports=3D | " > > @@ -109,6 +109,8 @@ usage(char* progname) > > printf(" --auto-start: start forwarding on init " > > "[always when non-interactive].\n"); > > printf(" --help: display this message and quit.\n"); > > + printf(" -T PERIOD: statistics will be shown every PERIOD seconds " >=20 > Considering all the option are in small letter, Does it makes sense to ma= ke it > as small letter? (ie -t instead of -T). >=20 > Other than it looks good and useful feature. >=20 > Tested-by: Jerin Jacob Thanks for the testing. I took the parameter name from L2fwd, but you are r= ight, it should be lowercase. Actually, to make it more explicit, I propose=20 to change it to "--stats-period". Will send a v5 soon. Thanks, Pablo