[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix typo error in comments

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix typo error in comments

[Akhil Goyal]

Comment for device name is corrected.
Also the name string is made similar to other pmds

Fixes: a3277ad47feb ("cryptodev: remove crypto device driver name")

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
index 2dac330..eafa0eb 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
@@ -34,8 +34,8 @@
 #ifndef _RTE_DPAA2_SEC_PMD_PRIVATE_H_
 #define _RTE_DPAA2_SEC_PMD_PRIVATE_H_
 
-#define CRYPTODEV_NAME_DPAA2_SEC_PMD	crypto_dpaa2_sec_pmd
-/**< Open SSL Crypto PMD device name */
+#define CRYPTODEV_NAME_DPAA2_SEC_PMD	crypto_dpaa2_sec
+/**< NXP DPAA2 - SEC PMD device name */
 
 #define MAX_QUEUES		64
 #define MAX_DESC_SIZE		64
-- 
2.9.3

[dpdk-dev] [PATCH] doc: add dpaa2-sec in test-crypto-perf

[Akhil Goyal]

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/tools/cryptoperf.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/tools/cryptoperf.rst b/doc/guides/tools/cryptoperf.rst
index 075a2bc..f24c26e 100644
--- a/doc/guides/tools/cryptoperf.rst
+++ b/doc/guides/tools/cryptoperf.rst
@@ -186,6 +186,7 @@ The following are the appication command-line options:
            crypto_snow3g
            crypto_kasumi
            crypto_zuc
+           crypto_dpaa2_sec
 
 * ``--optype <name>``
 
-- 
2.9.3

Re: [dpdk-dev] [PATCH] doc: add dpaa2-sec in test-crypto-perf

[De Lara Guarch, Pablo]

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, July 12, 2017 1:35 PM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH] doc: add dpaa2-sec in test-crypto-perf
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  doc/guides/tools/cryptoperf.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/tools/cryptoperf.rst
> b/doc/guides/tools/cryptoperf.rst index 075a2bc..f24c26e 100644
> --- a/doc/guides/tools/cryptoperf.rst
> +++ b/doc/guides/tools/cryptoperf.rst
> @@ -186,6 +186,7 @@ The following are the appication command-line
> options:
>             crypto_snow3g
>             crypto_kasumi
>             crypto_zuc
> +           crypto_dpaa2_sec
> 
>  * ``--optype <name>``
> 
> --
> 2.9.3

This is actually missing other PMDs that can be used, so we should send
a patch adding all of them in one go (crypto_armv8, crypto_scheduler and crypto_dpaa2_sec).

Could you send a v2 adding these three?

Thanks,
Pablo

[dpdk-dev] [PATCH v2] doc: add missing devices in test-crypto-perf

[Akhil Goyal]

crypto_armv8, crypto_scheduler and crypto_dpaa2_sec
are added in the documentation

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
changes in v2:
added crypto_armv8 and crypto_scheduler

 doc/guides/tools/cryptoperf.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/tools/cryptoperf.rst b/doc/guides/tools/cryptoperf.rst
index 075a2bc..457f817 100644
--- a/doc/guides/tools/cryptoperf.rst
+++ b/doc/guides/tools/cryptoperf.rst
@@ -186,6 +186,9 @@ The following are the appication command-line options:
            crypto_snow3g
            crypto_kasumi
            crypto_zuc
+           crypto_dpaa2_sec
+           crypto_armv8
+           crypto_scheduler
 
 * ``--optype <name>``
 
-- 
2.9.3

Re: [dpdk-dev] [PATCH v2] doc: add missing devices in test-crypto-perf

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, July 12, 2017 4:13 PM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH v2] doc: add missing devices in test-crypto-perf
> 
> crypto_armv8, crypto_scheduler and crypto_dpaa2_sec are added in the
> documentation
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Re: [dpdk-dev] [PATCH v2] doc: add missing devices in test-crypto-perf

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Wednesday, July 12, 2017 5:17 PM
> To: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; Doherty, Declan
> <declan.doherty@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] doc: add missing devices in test-crypto-
> perf
> 
> 
> 
> > -----Original Message-----
> > From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> > Sent: Wednesday, July 12, 2017 4:13 PM
> > To: dev@dpdk.org
> > Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> > <declan.doherty@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> > Subject: [PATCH v2] doc: add missing devices in test-crypto-perf
> >
> > crypto_armv8, crypto_scheduler and crypto_dpaa2_sec are added in the
> > documentation
> >
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix the incorrect free usage for dpsec

[Akhil Goyal]

dpseci is allocated using rte_calloc() but it is freed
using free(). Fixing it to use rte_free()

Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic operations")

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index d6c3088..9f2c0d9 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -1705,7 +1705,7 @@ dpaa2_sec_dev_close(struct rte_cryptodev *dev)
 
 	/*Free the allocated memory for ethernet private data and dpseci*/
 	priv->hw = NULL;
-	free(dpseci);
+	rte_free(dpseci);
 
 	return 0;
 }
-- 
2.9.3

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix the incorrect free usage for dpsec

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, July 12, 2017 1:35 PM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH] crypto/dpaa2_sec: fix the incorrect free usage for dpsec
> 
> dpseci is allocated using rte_calloc() but it is freed using free(). Fixing it to
> use rte_free()
> 
> Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic operations")
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>

Added Cc: stable@dpdk.org

Applied to dpdk-next-crypto.
Thanks,

Pablo

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix typo error in comments

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, July 12, 2017 1:35 PM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH] crypto/dpaa2_sec: fix typo error in comments
> 
> Comment for device name is corrected.
> Also the name string is made similar to other pmds
> 
> Fixes: a3277ad47feb ("cryptodev: remove crypto device driver name")
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo