From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C89BEA10 for ; Sun, 16 Jul 2017 12:57:12 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2017 03:57:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,368,1496127600"; d="scan'208";a="879378106" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 16 Jul 2017 03:57:11 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX102.ger.corp.intel.com ([169.254.2.211]) with mapi id 14.03.0319.002; Sun, 16 Jul 2017 11:57:10 +0100 From: "De Lara Guarch, Pablo" To: "Trahe, Fiona" , "Doherty, Declan" , "Jain, Deepak K" , "Griffin, John" , "Kusztal, ArkadiuszX" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters Thread-Index: AQHS/LLRIMr6xnQ/WUCnChWPsG2TU6JTd1mAgAAHr6CAAsvwMA== Date: Sun, 16 Jul 2017 10:57:10 +0000 Message-ID: References: <20170713074450.63682-1-pablo.de.lara.guarch@intel.com> <20170714070652.54494-1-pablo.de.lara.guarch@intel.com> <348A99DA5F5B7549AA880327E580B435892366A4@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435892366A4@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: fix KASUMI F9 expected parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jul 2017 10:57:13 -0000 > -----Original Message----- > From: Trahe, Fiona > Sent: Friday, July 14, 2017 5:17 PM > To: De Lara Guarch, Pablo ; Doherty, > Declan ; Jain, Deepak K > ; Griffin, John ; Kuszta= l, > ArkadiuszX > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters >=20 > Hi Pablo, >=20 > > -----Original Message----- > > From: Trahe, Fiona > > Sent: Friday, July 14, 2017 4:48 PM > > To: De Lara Guarch, Pablo ; Doherty, > > Declan ; Jain, Deepak K > > ; Griffin, John ; > > Kusztal, ArkadiuszX > > Cc: dev@dpdk.org > > Subject: RE: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters > > > > > > > > > -----Original Message----- > > > From: De Lara Guarch, Pablo > > > Sent: Friday, July 14, 2017 8:07 AM > > > To: Doherty, Declan ; Trahe, Fiona > > > ; Jain, Deepak > > K > > > ; Griffin, John ; > > > Kusztal, ArkadiuszX > > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > > > > > Subject: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters > > > > > > For KASUMI F9 algorithm, COUNT, FRESH and DIRECTION input values > > > need to be contiguous with the message, as described in the KASUMI > > > and QAT PMD documentation. > > > > > > Before, the COUNT and FRESH values were set as part of the AAD (now > > > IV), but always set before the beginning of the message. > > > Since now the IV is set after the crypto operation, it is not > > > possible to have these values in the expected location. > > > > > > Therefore, as these are required to be contiguous, cryptodev API > > > will expect these them to be passed as a single buffer, already > > > constructed, so authentication IV parameters not needed anymore. > > > > > > Fixes: 681f540da52b ("cryptodev: do not use AAD in wireless > > > algorithms") > > > > > > Signed-off-by: Pablo de Lara > > Acked-by: Fiona Trahe >=20 > The limitation in QAT documentation stating that Kasumi F9 auth_len and > auth_offset must be byte-multiples can be removed as this is now a > limitation on the API, not on QAT. Removed that before applying to subtree. Applied to dpdk-next-crypto. Pablo