From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 880093253; Tue, 18 Jul 2017 18:21:11 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2017 09:21:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,378,1496127600"; d="scan'208";a="1152746385" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 18 Jul 2017 09:21:09 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 18 Jul 2017 17:21:08 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX156.ger.corp.intel.com ([10.108.20.68]) with mapi id 14.03.0319.002; Tue, 18 Jul 2017 17:21:08 +0100 From: "De Lara Guarch, Pablo" To: Yuanhan Liu CC: Akhil Goyal , "dev@dpdk.org" , "stable@dpdk.org" , "hemant.agrawal@nxp.com" Thread-Topic: [PATCH v2] crypto/dpaa2_sec: fix the return of supported API Thread-Index: AQHS/5h7JUiBNLN/3kWOMyW7uUAJjKJZR0GAgABQAoCAACyIQA== Date: Tue, 18 Jul 2017 16:21:08 +0000 Message-ID: References: <20170718073356.14288-1-akhil.goyal@nxp.com> <20170718143907.GV11626@yliu-home> In-Reply-To: <20170718143907.GV11626@yliu-home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 16:21:13 -0000 HI Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > Sent: Tuesday, July 18, 2017 3:39 PM > To: De Lara Guarch, Pablo > Cc: Akhil Goyal ; dev@dpdk.org; stable@dpdk.org; > hemant.agrawal@nxp.com > Subject: Re: [PATCH v2] crypto/dpaa2_sec: fix the return of supported API >=20 > On Tue, Jul 18, 2017 at 10:26:39AM +0000, De Lara Guarch, Pablo wrote: > > Hi Akhil, > > > > > -----Original Message----- > > > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > > > Sent: Tuesday, July 18, 2017 8:34 AM > > > To: dev@dpdk.org; stable@dpdk.org > > > Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo > > > ; yliu@fridaylinux.org; Akhil Goyal > > > > > > Subject: [PATCH v2] crypto/dpaa2_sec: fix the return of supported > > > API > > > > > > call to dpaa2_sec_dev_configure() is made mandatory, but > > > dpaa2_sec_pmd returns a ENOTSUP which results in device not getting > configured. > > > > > > dpaa2_sec PMD does not need any further configuration to be done in > > > dpaa2_sec_dev_configure, hence returning 0 > > > > > > Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic operations") > > > > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Akhil Goyal > > > > Looks ok to me, but this is only applicable in the stable branch, so > > no need to send it to dev@dpdk.org. >=20 > Why? We already have such fix in upstream? Normally, we just pick > upstream commits (but not patches: the emails) to stable release. It looks like this fix was included in 13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR"). Unfortunately, this patch should have been split into two different patches= . Since this has already been merged, I think our only way to integrate this In 17.05.1 is by getting it separately. Pablo >=20 > --yliu