From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0179F2030 for ; Wed, 19 Jul 2017 16:36:07 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 19 Jul 2017 07:36:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,381,1496127600"; d="scan'208";a="129300312" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga006.fm.intel.com with ESMTP; 19 Jul 2017 07:36:06 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 19 Jul 2017 15:36:05 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by irsmsx155.ger.corp.intel.com ([169.254.14.182]) with mapi id 14.03.0319.002; Wed, 19 Jul 2017 15:36:04 +0100 From: "De Lara Guarch, Pablo" To: "Doherty, Declan" , "Rybalchenko, Kirill" , "Zhang, Roy Fan" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] crypto/scheduler: fix multicore scheduler reordering Thread-Index: AQHS/7G3DgoHALAZzkqBvaphJgt1mKJbH1mAgAAZ7kA= Date: Wed, 19 Jul 2017 14:36:04 +0000 Message-ID: References: <1500374138-6262-1-git-send-email-kirill.rybalchenko@intel.com> <96dc8c1e-b5a7-2de7-93db-4b53d7d04d5f@intel.com> In-Reply-To: <96dc8c1e-b5a7-2de7-93db-4b53d7d04d5f@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] crypto/scheduler: fix multicore scheduler reordering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 14:36:08 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty > Sent: Wednesday, July 19, 2017 3:03 PM > To: Rybalchenko, Kirill ; Zhang, Roy Fan > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] crypto/scheduler: fix multicore > scheduler reordering >=20 > On 18/07/2017 11:35 AM, Kirill Rybalchenko wrote: > > Operations can be dequeued from the reordering ring only after they > > were dequeued from the crypto pmd with > rte_cryptodev_dequeue_burst() > > function. It is not correct to dequeue them when status just changed > > from RTE_CRYPTO_OP_STATUS_NOT_PROCESSED to any other value, as > the > > operations still can be processed by crypto pmd internally. > > Now multicore scheduler workers mark status of all dequeued from > > crypto pmd operations with CRYPTO_OP_STATUS_BIT_COMPLETE bit set. > > Scheduler will dequeue crypto operations from reordering ring only > > when this status bit is set. Prior to put this operation to output > > buffer, scheduler clears this bit, so the application gets unmodified > > status from crypto pmd. > > > > Fixes: 4c07e0552f0a ("crypto/scheduler: add multicore scheduling > > mode") > > > > Signed-off-by: Kirill Rybalchenko > > --- > ... > > > Acked-by: Declan Doherty Applied to dpdk-next-crypto. Thanks, Pablo