From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A68443253 for ; Wed, 19 Jul 2017 16:37:13 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 19 Jul 2017 07:37:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,381,1496127600"; d="scan'208";a="1197246338" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 19 Jul 2017 07:37:10 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 19 Jul 2017 15:37:09 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by irsmsx155.ger.corp.intel.com ([169.254.14.182]) with mapi id 14.03.0319.002; Wed, 19 Jul 2017 15:37:08 +0100 From: "De Lara Guarch, Pablo" To: "Trahe, Fiona" , "Jain, Deepak K" , "Griffin, John" CC: "dev@dpdk.org" Thread-Topic: [PATCH] crypto/qat: fix session initialization Thread-Index: AQHTAI7ErJUeRQ2LyUKmZf+QSO/77aJbHnAAgAAZKWA= Date: Wed, 19 Jul 2017 14:37:08 +0000 Message-ID: References: <20170719045902.12110-1-pablo.de.lara.guarch@intel.com> <348A99DA5F5B7549AA880327E580B435892389FC@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435892389FC@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix session initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 14:37:14 -0000 > -----Original Message----- > From: Trahe, Fiona > Sent: Wednesday, July 19, 2017 3:06 PM > To: De Lara Guarch, Pablo ; Jain, Deepak = K > ; Griffin, John > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [PATCH] crypto/qat: fix session initialization >=20 >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Wednesday, July 19, 2017 5:59 AM > > To: Trahe, Fiona ; Jain, Deepak K > > ; Griffin, John > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > > > Subject: [PATCH] crypto/qat: fix session initialization > > > > When creating a session, if there is a failure when setting some of > > the parameters, QAT was not propagating the error to the session > > initialization function. > > Therefore, it was reporting a success, when it should be report a > > failure. > > > > Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions") > > > > Signed-off-by: Pablo de Lara > In the 3 fn prototypes in qat_crypto.h it would be nice to remove the > _private from struct qat_session *session_private. Apart from that it's f= ine. >=20 > Acked-by: Fiona Trahe I fixed that when merging the patch :) Thanks! Applied to dpdk-next-crypto. Pablo