DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
Date: Thu, 27 Jul 2017 14:33:38 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBE3737@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <5657ecf7-2fba-ab6d-01a4-abd88e2c71c9@nxp.com>



> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Thursday, July 27, 2017 12:43 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: hemant.agrawal@nxp.com
> Subject: Re: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
> 
> On 7/27/2017 2:22 PM, De Lara Guarch, Pablo wrote:
> > HI Akhil,
> >
> >> -----Original Message-----
> >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> >> Sent: Wednesday, July 26, 2017 12:28 PM
> >> To: dev@dpdk.org
> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> >> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>
> >> Subject: [PATCH] crypto/dpaa2_sec: add check for gcc toolchain
> >>
> >> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> >
> > I think you need to include a fixes line here, and CC stable, as this is a fix.
> >
> 
> This is not valid for 17.05 stable release. This is recently added in below
> commit. Should I resend this patch with commit message updated?
> 
>   ed5ed6b344f2 ("crypto/dpaa2_sec: remove GCC 7.1 compilation error")
> 
> Thanks,
> Akhil

Added fixes line [Fixes: 6a95466d78de ("crypto/dpaa2_sec: fix build with gcc 7.1")].
Remember to use the commit ID of the patch that was actually merged.

Applied to dpdk-next-crypto.
Thanks,

Pablo


      parent reply	other threads:[~2017-07-27 14:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 11:27 Akhil Goyal
2017-07-27  8:52 ` De Lara Guarch, Pablo
2017-07-27 11:42   ` Akhil Goyal
2017-07-27 12:48     ` De Lara Guarch, Pablo
2017-07-27 14:33     ` De Lara Guarch, Pablo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBE3737@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).