From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2C77B910F; Thu, 27 Jul 2017 17:57:25 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jul 2017 08:57:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,421,1496127600"; d="scan'208";a="132020877" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga005.fm.intel.com with ESMTP; 27 Jul 2017 08:57:24 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX109.ger.corp.intel.com ([169.254.13.187]) with mapi id 14.03.0319.002; Thu, 27 Jul 2017 16:57:23 +0100 From: "De Lara Guarch, Pablo" To: "Trahe, Fiona" , "Doherty, Declan" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc Doxygen Thread-Index: AQHTBgp5X/xetGfyVkmUFelk8imS7qJnUXsAgACBt1A= Date: Thu, 27 Jul 2017 15:57:23 +0000 Message-ID: References: <20170726042712.8355-1-pablo.de.lara.guarch@intel.com> <348A99DA5F5B7549AA880327E580B4358923CF56@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B4358923CF56@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc Doxygen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2017 15:57:26 -0000 > -----Original Message----- > From: Trahe, Fiona > Sent: Thursday, July 27, 2017 10:03 AM > To: De Lara Guarch, Pablo ; Doherty, > Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo > ; stable@dpdk.org; Trahe, Fiona > > Subject: RE: [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc Doxyg= en >=20 > Hi Pablo, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > > Sent: Wednesday, July 26, 2017 5:27 AM > > To: Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] cryptodev: fix crypto op bulk alloc > > Doxygen > > > > When calling rte_crypto_op_bulk_alloc, the function may return either > > a 0, if not enough objects are available in the mempool or the number > > of operations requested, it there are enough available. However, the > > Doxygen comments were not matching these two cases. > > > > Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op > > oriented") > > Cc: stable@dpdk.org > > > > Signed-off-by: Pablo de Lara > > --- > > lib/librte_cryptodev/rte_crypto.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lib/librte_cryptodev/rte_crypto.h > > b/lib/librte_cryptodev/rte_crypto.h > > index 0908368..9f10818 100644 > > --- a/lib/librte_cryptodev/rte_crypto.h > > +++ b/lib/librte_cryptodev/rte_crypto.h > > @@ -266,8 +266,8 @@ rte_crypto_op_alloc(struct rte_mempool > *mempool, > > enum rte_crypto_op_type type) > > * @param nb_ops Number of crypto operations to allocate > > * > > * @returns > > - * - On success returns a valid rte_crypto_op structure > > - * - On failure returns NULL > > + * - 0 if no operations could be allocated > > + * - nb_ops if the number of operations requested were allocated > > */ > > > My first thought was what's returned if some ops could be allocated, but > not the requested number? > Maybe instead: > - nb_ops if the number of operations requested were allocated. > - 0 if the requested number of ops are not available. None are allocated = in > this case. Good clarification. Will send a v2 shortly. Thanks, Pablo >=20 > > static inline unsigned > > -- > > 2.9.4