[dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

[dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

[Jan Blunck]

This function is an alias for rte_vdev_init() which is scheduled to move
out of the rte_eal library. Lets deprecate this function to be able to
remove it from the cryptodev library in 17.11.

Signed-off-by: Jan Blunck <jblunck@infradead.org>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 lib/librte_cryptodev/rte_cryptodev.h | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 257dcba32..3c687b1b8 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -64,3 +64,8 @@ Deprecation Notices
   be removed in 17.11:
 
   - ``rte_eal_parse_devargs_str``, replaced by ``rte_eal_devargs_parse``
+
+* cryptodev: the following function is deprecated starting from 17.08 and will
+  be removed in 17.11:
+
+  - ``rte_cryptodev_create_vdev``
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 2048d6e29..39253a8e2 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -435,6 +435,8 @@ struct rte_cryptodev_stats {
 /**< Max length of name of crypto PMD */
 
 /**
+ * @deprecated
+ *
  * Create a virtual crypto device
  *
  * @param	name	Cryptodev PMD name of device to be created.
@@ -445,6 +447,7 @@ struct rte_cryptodev_stats {
  *   which will be between 0 and rte_cryptodev_count().
  * - In the case of a failure, returns -1.
  */
+__rte_deprecated
 extern int
 rte_cryptodev_create_vdev(const char *name, const char *args);
 
-- 
2.13.2

Re: [dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Jan Blunck [mailto:jblunck@gmail.com] On Behalf Of Jan Blunck
> Sent: Wednesday, July 12, 2017 9:16 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()
> 
> This function is an alias for rte_vdev_init() which is scheduled to move out
> of the rte_eal library. Lets deprecate this function to be able to remove it
> from the cryptodev library in 17.11.
> 
> Signed-off-by: Jan Blunck <jblunck@infradead.org>

Funny, I thought I submitted this patch yesterday, but forgot to cc the mailing list :)
Obviously then:

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Re: [dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

[Declan Doherty]

On 12/07/2017 9:15 PM, Jan Blunck wrote:
> This function is an alias for rte_vdev_init() which is scheduled to move
> out of the rte_eal library. Lets deprecate this function to be able to
> remove it from the cryptodev library in 17.11.
>
> Signed-off-by: Jan Blunck <jblunck@infradead.org>
> ---
...
>

Acked-by: Declan Doherty <declan.doherty@intel.com>

Re: [dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

[Sergio Gonzalez Monroy]

On 12/07/2017 21:15, Jan Blunck wrote:
> This function is an alias for rte_vdev_init() which is scheduled to move
> out of the rte_eal library. Lets deprecate this function to be able to
> remove it from the cryptodev library in 17.11.
>
> Signed-off-by: Jan Blunck <jblunck@infradead.org>
> ---

Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

Re: [dpdk-dev] [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Jan Blunck [mailto:jblunck@gmail.com] On Behalf Of Jan Blunck
> Sent: Wednesday, July 12, 2017 9:16 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] cryptodev: deprecate rte_cryptodev_create_vdev()
> 
> This function is an alias for rte_vdev_init() which is scheduled to move out
> of the rte_eal library. Lets deprecate this function to be able to remove it
> from the cryptodev library in 17.11.
> 
> Signed-off-by: Jan Blunck <jblunck@infradead.org>

Applied to dpdk-next-crypto.
Thanks,

Pablo