From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5CF81911B for ; Tue, 1 Aug 2017 14:54:45 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2017 05:54:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,306,1498546800"; d="scan'208";a="114276199" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga004.jf.intel.com with ESMTP; 01 Aug 2017 05:54:44 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX107.ger.corp.intel.com ([169.254.10.129]) with mapi id 14.03.0319.002; Tue, 1 Aug 2017 13:54:43 +0100 From: "De Lara Guarch, Pablo" To: "Hunt, David" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Hunt, David" Thread-Topic: [dpdk-dev] [PATCH v1] app/testpmd: fix Tx first with LSC interrupt Thread-Index: AQHTBTLwgV5t4c2YQU615a5/yarqQaJvgDMw Date: Tue, 1 Aug 2017 12:54:42 +0000 Message-ID: References: <1500978472-182803-1-git-send-email-david.hunt@intel.com> In-Reply-To: <1500978472-182803-1-git-send-email-david.hunt@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix Tx first with LSC interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2017 12:54:46 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt > Sent: Tuesday, July 25, 2017 11:28 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Hunt, David > > Subject: [dpdk-dev] [PATCH v1] app/testpmd: fix Tx first with LSC interru= pt >=20 > The lsc_interrupt flag is enabled by default, and when the --tx-first is = used > as a command line parameter, the 32 packets can be sent out before the > link state is up, resulting in the loss of the packets, and no further > forwarding will take place. >=20 > E.g. ./build/app/testpmd -c f0 -- --tx-first --stats-period 1 >=20 > When the --tx-first is used, the lsc_interrupt flag needs to be disabled, > ensuring the links are up before forwarding traffic. Therefore, during t= he > parameter checking at startup, if --tx-first is used, we now warn the use= r, > and set lsc_interrupt to 0. >=20 > Fixes: 99cabef08855 ("app/testpmd: add parameter to start forwarding Tx > first") > Signed-off-by: David Hunt Acked-by: Pablo de Lara