From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pablo.de.lara.guarch@intel.com> Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EA6572BC7 for <dev@dpdk.org>; Tue, 8 Aug 2017 10:09:04 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 08 Aug 2017 01:09:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,342,1498546800"; d="scan'208";a="1203224505" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 08 Aug 2017 01:09:01 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.133]) by IRSMSX103.ger.corp.intel.com ([169.254.3.9]) with mapi id 14.03.0319.002; Tue, 8 Aug 2017 09:09:00 +0100 From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>, "Doherty, Declan" <declan.doherty@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "Nicolau, Radu" <radu.nicolau@intel.com>, "aviadye@mellanox.com" <aviadye@mellanox.com>, "borisp@mellanox.com" <borisp@mellanox.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com> CC: "shahafs@mellanox.com" <shahafs@mellanox.com> Thread-Topic: [PATCH v2] doc: announce ABI change for cryptodev and ethdev Thread-Index: AQHTEBWcFYNLkXwioEWQcZcsJkLz4aJ6GDQw Date: Tue, 8 Aug 2017 08:08:59 +0000 Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBE9F9E@IRSMSX108.ger.corp.intel.com> References: <20170803153211.23073-1-akhil.goyal@nxp.com> <20170808070943.24415-1-akhil.goyal@nxp.com> In-Reply-To: <20170808070943.24415-1-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for cryptodev and ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 08 Aug 2017 08:09:06 -0000 Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Tuesday, August 8, 2017 8:10 AM > To: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>; > thomas@monjalon.net; Nicolau, Radu <radu.nicolau@intel.com>; > aviadye@mellanox.com; borisp@mellanox.com; > hemant.agrawal@nxp.com; De Lara Guarch, Pablo > <pablo.de.lara.guarch@intel.com> > Cc: shahafs@mellanox.com; Akhil Goyal <akhil.goyal@nxp.com> > Subject: [PATCH v2] doc: announce ABI change for cryptodev and ethdev >=20 > Support for security operations is planned to be added in ethdev and > cryptodev for the 17.11 release. >=20 > For this following changes are required. > - rte_cryptodev and rte_eth_dev structures need to be added new > parameter rte_security_ops which extend support for security ops to the > corresponding driver. > - rte_cryptodev_info and rte_eth_dev_info need to be added with > rte_security_capabilities to identify the capabilities of the correspondi= ng > driver. > - rte_security_session needs to be added in the union inside structure > rte_crypto_sym_op to decide between various types of sessions >=20 > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com> > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> > Acked-by: Boris Pismenny <borisp@mellanox.com> > Acked-by: Shahaf Shuler <shahafs@mellanox.com> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > --- > changes in v2: > Added one more ABI change wrt to security session, This patch is not spli= t > into 3 patches as these all will be implemented simultaneously with > rte_security support. >=20 > doc/guides/rel_notes/deprecation.rst | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 72d1f35..e34a809 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -78,3 +78,18 @@ Deprecation Notices > be removed in 17.11: >=20 > - ``rte_cryptodev_create_vdev`` > + > +* cryptodev: new parameters - ``rte_security_capabilities`` and > + ``rte_security_ops`` will be added to ``rte_cryptodev_info`` and > + ``rte_cryptodev`` respectively to support security protocol offloaded > + operations. > + > +* cryptodev: new parameter ``rte_security_session`` will be added in > +the union > + of the structure ``rte_crypto_sym_op``, so that the user can choose > +either to > + use ``rte_cryptodev_sym_session`` or ``rte_crypto_sym_xform`` or > + ``rte_security_session``. I don't think it is required to have a deprecation notice for this, as it i= s adding another element in a union, and it is not changing its size. However, this would require an addition in rte_crypto_op_sess_type, which, as long as it is added at the end, should not require a deprecation notice. About splitting this into two patches, I would do it, as I believe deprecat= ion notices should target a specific library.