From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4B2B17CA9 for ; Mon, 14 Aug 2017 16:17:47 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP; 14 Aug 2017 07:17:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,373,1498546800"; d="scan'208";a="140016031" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga006.fm.intel.com with ESMTP; 14 Aug 2017 07:17:45 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.220]) by IRSMSX154.ger.corp.intel.com ([169.254.12.54]) with mapi id 14.03.0319.002; Mon, 14 Aug 2017 15:17:44 +0100 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" , "Doherty, Declan" CC: "hemant.agrawal@nxp.com" Thread-Topic: [PATCH] crypto/openssl: performance improvements Thread-Index: AQHTB5IPvpDGNev+H0+dN9Ct0PXHhaKD/5dQ Date: Mon, 14 Aug 2017 14:17:43 +0000 Message-ID: References: <20170728110738.28922-1-akhil.goyal@nxp.com> <20170728110738.28922-3-akhil.goyal@nxp.com> In-Reply-To: <20170728110738.28922-3-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: performance improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Aug 2017 14:17:47 -0000 Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Friday, July 28, 2017 12:08 PM > To: dev@dpdk.org; Doherty, Declan > Cc: De Lara Guarch, Pablo ; > hemant.agrawal@nxp.com; Akhil Goyal > Subject: [PATCH] crypto/openssl: performance improvements >=20 > key and algo are added in the openssl ctx during session initialization > instead of adding it for each packet. >=20 > Also in case of HMAC the openssl APIs HMAC_XXX give better performance > for all HMAC cases. >=20 > Signed-off-by: Akhil Goyal Thanks for the patch, nice optimization! Could you split this into two patches, as you are doing two different thing= s here? One for the first sentence and another one for the second sentence. Also, as you do that, could you rename the title to be more explicit? Like: crypto/openssl: initialize cipher key at session init Finally, I was looking at GCM, and I think it could benefit from this. I will send a separate patch for it, unless you want to integrate it in thi= s patchset yourself. Thanks, Pablo