DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] crypto/ccp: Add support for AMD CCP Crypto poll	mode driver
Date: Mon, 4 Sep 2017 15:36:04 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC1578A@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <DM5PR12MB11298DC7A904E64FE4D10FD7AE9C0@DM5PR12MB1129.namprd12.prod.outlook.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kumar, Ravi1
> Sent: Wednesday, August 30, 2017 7:25 AM
> To: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] crypto/ccp: Add support for AMD CCP
> Crypto poll mode driver
> 
> Hi,
> 
> Please do not consider this patch as the license has to be updated. We are
> working with our legal team to get that done.

Hi Ravi,

I have several comments about this patch, for the v2 that you will send:

- Could you split the patch into separate patches? The patch is quite big to be reviewed easily.
  Here it is an example of how you should do it:
  http://dpdk.org/ml/archives/dev/2017-April/064385.html

- When including a file that is in the same folder, use quotes:
  #include <ccp_crypto.h> --> #include "ccp_crypto.h".

- There are some checkpatch errors. Look at patchwork:
  http://dpdk.org/ml/archives/test-report/2017-August/027829.html

- I think you should add some tests for this PMD. You don't really need to add
 new tests, you can just add a test suite for this driver and use the existing tests.

Last thing, when replying to a patch, comment inline and use ">" before each line,
otherwise patchwork picks up the email as a new patch.

Thanks!
Pablo

  reply	other threads:[~2017-09-04 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25 15:45 Ravi Kumar
2017-08-30  6:24 ` Kumar, Ravi1
2017-09-04 15:36   ` De Lara Guarch, Pablo [this message]
2017-09-15 12:34     ` Kumar, Ravi1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC1578A@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=Ravi1.Kumar@amd.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).