From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 12425107A for ; Wed, 6 Sep 2017 11:02:10 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2017 02:02:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,483,1498546800"; d="scan'208";a="1169556776" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga001.jf.intel.com with ESMTP; 06 Sep 2017 02:02:08 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX106.ger.corp.intel.com ([169.254.8.36]) with mapi id 14.03.0319.002; Wed, 6 Sep 2017 10:02:06 +0100 From: "De Lara Guarch, Pablo" To: "jerin.jacob@caviumnetworks.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 2/8] crypto/armv8: do not append digest Thread-Index: AQHTJjCO6KbtwDOkaUaR9fNTeVqCLqKnkKaA Date: Wed, 6 Sep 2017 09:02:06 +0000 Message-ID: References: <20170818072103.1416-1-pablo.de.lara.guarch@intel.com> <20170905022007.55749-1-pablo.de.lara.guarch@intel.com> <20170905022007.55749-3-pablo.de.lara.guarch@intel.com> In-Reply-To: <20170905022007.55749-3-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/8] crypto/armv8: do not append digest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 09:02:11 -0000 Hi Jerin, > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Tuesday, September 5, 2017 3:20 AM > To: Doherty, Declan ; Zhang, Roy Fan > ; jerin.jacob@caviumnetworks.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH v2 2/8] crypto/armv8: do not append digest >=20 > When performing an authentication verification, the PMD was using > memory at the end of the input buffer, to store temporarily the digest. > This operation requires the buffer to have enough tailroom unnecessarily. > Instead, memory is allocated for each queue pair, to store temporarily th= e > digest generated by the driver, so it can be compared with the one provid= ed > in the crypto operation, without needing to touch the input buffer. >=20 > Signed-off-by: Pablo de Lara Could you take a look at this patch? The series have been acked by Fan Zhang, but this patch affects the ARMv8 P= MD, So I would prefer applying it after your review. Thanks, Pablo