From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 0B59D7CAE for ; Fri, 8 Sep 2017 16:04:03 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Sep 2017 07:04:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,361,1500966000"; d="scan'208";a="1192992789" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 08 Sep 2017 07:04:00 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX102.ger.corp.intel.com ([169.254.2.59]) with mapi id 14.03.0319.002; Fri, 8 Sep 2017 15:04:00 +0100 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" , "Doherty, Declan" Thread-Topic: [PATCH v2 1/2] crypto/openssl: replace evp APIs with HMAC APIs Thread-Index: AQHTIJSf6F1l/jNKe0CuNe9Yr666AaKrE9Lw Date: Fri, 8 Sep 2017 14:03:59 +0000 Message-ID: References: <20170728110738.28922-3-akhil.goyal@nxp.com> <20170829065849.11424-1-akhil.goyal@nxp.com> In-Reply-To: <20170829065849.11424-1-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDAwMmE5NTMtZWRmNS00OGIyLThiODAtNDM0YmVkZGQ4MGYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkVXbmRPelpra1FEb3ZMYWlRYkc1Z1E4d1d3UWFQaUk3bCt5NzVoYUVwcG89In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] crypto/openssl: replace evp APIs with HMAC APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2017 14:04:04 -0000 Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Tuesday, August 29, 2017 7:59 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > > Cc: hemant.agrawal@nxp.com; Doherty, Declan > ; Akhil Goyal > Subject: [PATCH v2 1/2] crypto/openssl: replace evp APIs with HMAC APIs >=20 > in case of HMAC the openssl APIs HMAC_XXX give better performance for > all HMAC cases as compared with EVP_XXX >=20 > Signed-off-by: Akhil Goyal > --- > changes in v2: > patch split in two patches as per Pablo's recommendations >=20 > drivers/crypto/openssl/rte_openssl_pmd.c | 37 +++++++++++++-----= -- I just come across an issue with this patch on openssl 1.1.0 (below). Unfortunately, I have already applied the patch in the subtree, but if you = could send a patch to fix this, I can integrate as part of that patch. Thanks, Pablo drivers/crypto/openssl/rte_openssl_pmd_private.h:168:14: error: field 'ctx'= has incomplete type HMAC_CTX ctx; ^~~ In file included from drivers/crypto/openssl/rte_openssl_pmd_ops.c:39:0: drivers/crypto/openssl/rte_openssl_pmd_private.h:168:14: error: field 'ctx'= has incomplete type HMAC_CTX ctx; ^~~ drivers/crypto/openssl/rte_openssl_pmd.c: In function 'openssl_set_session_= auth_parameters': drivers/crypto/openssl/rte_openssl_pmd.c:440:3: error: implicit declaration= of function 'HMAC_CTX_init'; did you mean 'HMAC_CTX_new'? [-Werror=3Dimpli= cit-function-declaration] HMAC_CTX_init(&sess->auth.hmac.ctx); ^~~~~~~~~~~~~ HMAC_CTX_new drivers/crypto/openssl/rte_openssl_pmd.c:440:3: error: nested extern declar= ation of 'HMAC_CTX_init' [-Werror=3Dnested-externs] make[4]: *** [mk/internal/rte.compile-pre.mk:140: rte_openssl_pmd_ops.o] Er= ror 1 make[4]: *** Waiting for unfinished jobs.... drivers/crypto/openssl/rte_openssl_pmd.c: In function 'openssl_reset_sessio= n': drivers/crypto/openssl/rte_openssl_pmd.c:588:3: error: implicit declaration= of function 'HMAC_CTX_cleanup'; did you mean 'HMAC_CTX_get_md'? [-Werror= =3Dimplicit-function-declaration] HMAC_CTX_cleanup(&sess->auth.hmac.ctx); ^~~~~~~~~~~~~~~~ HMAC_CTX_get_md drivers/crypto/openssl/rte_openssl_pmd.c:588:3: error: nested extern declar= ation of 'HMAC_CTX_cleanup' [-Werror=3Dnested-externs] cc1: all warnings being treated as errors make[4]: *** [mk/internal/rte.compile-pre.mk:140: rte_openssl_pmd.o] Error = 1