From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 53D5C11DE for ; Thu, 5 Oct 2017 10:54:11 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2017 01:54:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,480,1500966000"; d="scan'208";a="156998739" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga005.jf.intel.com with ESMTP; 05 Oct 2017 01:54:08 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX109.ger.corp.intel.com ([169.254.13.28]) with mapi id 14.03.0319.002; Thu, 5 Oct 2017 09:54:04 +0100 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" CC: "Doherty, Declan" , "hemant.agrawal@nxp.com" , "Nicolau, Radu" , "borisp@mellanox.com" , "aviadye@mellanox.com" , "thomas@monjalon.net" , "sandeep.malik@nxp.com" , "jerin.jacob@caviumnetworks.com" , "Mcnamara, John" , "olivier.matz@6wind.com" Thread-Topic: [PATCH v2 05/12] lib/librte_mbuf: add security crypto flags and mbuf fields Thread-Index: AQHTPEn2zbVx6J9sXk+iCqVyc2p96qLU9V3Q Date: Thu, 5 Oct 2017 08:54:04 +0000 Message-ID: References: <20170914082651.26232-1-akhil.goyal@nxp.com> <20171003131413.23846-1-akhil.goyal@nxp.com> <20171003131413.23846-6-akhil.goyal@nxp.com> In-Reply-To: <20171003131413.23846-6-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTUxZWJkYjgtNjQ5Zi00NmZjLWIzYjItMzkwMDlkOWRlODk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZwUW96UEhUaHBlbnVJcmIyelRWYUFBZm9PNzd6YnhIU2VtbGtUOVB1anc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 05/12] lib/librte_mbuf: add security crypto flags and mbuf fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 08:54:11 -0000 > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Tuesday, October 3, 2017 2:14 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agrawal@nxp.com; Nicolau, > Radu ; borisp@mellanox.com; > aviadye@mellanox.com; thomas@monjalon.net; sandeep.malik@nxp.com; > jerin.jacob@caviumnetworks.com; Mcnamara, John > ; olivier.matz@6wind.com > Subject: [PATCH v2 05/12] lib/librte_mbuf: add security crypto flags and > mbuf fields >=20 > From: Boris Pismenny >=20 Quick comment about the commit message: 1 - For libraries, there is no need to use "lib/librte...". The convention is to directly use the library name: In this case: "mbuf: add security...". Same applies to patch 4. Also, make sure that the commit message starts with capital letter. Thanks, Pablo > add security crypto flags and update mbuf fields to support IPsec crypto > offload for transmitted packets, and to indicate crypto result for receiv= ed > packets. >=20