From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 237DD1B214 for ; Tue, 10 Oct 2017 12:16:45 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 10 Oct 2017 03:16:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,504,1500966000"; d="scan'208";a="144780276" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga002.jf.intel.com with ESMTP; 10 Oct 2017 03:16:43 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX151.ger.corp.intel.com ([169.254.4.108]) with mapi id 14.03.0319.002; Tue, 10 Oct 2017 11:16:42 +0100 From: "De Lara Guarch, Pablo" To: Tomasz Duszynski , "dev@dpdk.org" CC: "mw@semihalf.com" , "dima@marvell.com" , "nsamsono@marvell.com" , "Jianbo.liu@linaro.org" , Jacek Siuda Thread-Topic: [dpdk-dev] [PATCH v3 1/4] crypto/mrvl: add mrvl crypto pmd driver Thread-Index: AQHTP6r0RR7/noCiwUyKrh6RKo4TCaLc4RLA Date: Tue, 10 Oct 2017 10:16:42 +0000 Message-ID: References: <1506594212-15803-1-git-send-email-tdu@semihalf.com> <1507408106-11292-1-git-send-email-tdu@semihalf.com> <1507408106-11292-2-git-send-email-tdu@semihalf.com> In-Reply-To: <1507408106-11292-2-git-send-email-tdu@semihalf.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGZiZTU5ZTAtYWNmYy00ZmIzLWI2MDUtNmY3NmE4YWFhNzMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ijg3eWVyM2M2MHNpTUs2TjQ5QklzYzdCbjh1ZnpzRGRhUTNxZXNiN09ZaWc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/4] crypto/mrvl: add mrvl crypto pmd driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 10:16:46 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Saturday, October 7, 2017 9:28 PM > To: dev@dpdk.org > Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com; > Jianbo.liu@linaro.org; Tomasz Duszynski ; Jacek Siuda > > Subject: [dpdk-dev] [PATCH v3 1/4] crypto/mrvl: add mrvl crypto pmd > driver ... > diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd.c > b/drivers/crypto/mrvl/rte_mrvl_pmd.c > new file mode 100644 > index 0000000..a404bf4 > --- /dev/null > +++ b/drivers/crypto/mrvl/rte_mrvl_pmd.c ... > + > +/* Register the driver in constructor. */ > +RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_MRVL_PMD, > cryptodev_mrvl_pmd_drv); > +RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_MRVL_PMD, > + "max_nb_queue_pairs=3D " > + "max_nb_sessions=3D " > + "socket_id=3D"); > +RTE_PMD_REGISTER_CRYPTO_DRIVER(cryptodev_mrvl_pmd_drv, > cryptodev_driver_id); This macro now needs 3 parameters. You probably rebased the patchset against the main repo, and not dpdk-next-crypto. Just a reminder that all crypto patches should target this repository. Apart from this, the rest of the patchset looks good to me. So send a v4 and hopefully it can be merged in RC1. Pablo