From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C636B7D34 for ; Wed, 11 Oct 2017 12:09:05 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2017 03:09:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,360,1503385200"; d="scan'208";a="137375953" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga004.jf.intel.com with ESMTP; 11 Oct 2017 03:09:03 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Wed, 11 Oct 2017 11:09:02 +0100 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , Tomasz Duszynski CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto: use snprintf return value correctly Thread-Index: AQHTQnMGGc7WAYblrEuCqj6h4dnNUKLeWS0AgAATOnA= Date: Wed, 11 Oct 2017 10:09:02 +0000 Message-ID: References: <1507713940-12268-1-git-send-email-tdu@semihalf.com> <20171011095800.GA43968@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20171011095800.GA43968@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWU4NDBhYzgtN2RlYi00MjA4LWI1MDYtZDliZjUxMjVjNWZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkUwZTVka3diM3Fja2ZkSmdaTFA0SHZmbkhPVUdSSWszUFN5andpYXB6RGs9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto: use snprintf return value correctly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 10:09:06 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, October 11, 2017 10:58 AM > To: Tomasz Duszynski > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] crypto: use snprintf return value correct= ly >=20 > On Wed, Oct 11, 2017 at 11:25:40AM +0200, Tomasz Duszynski wrote: > > snprintf return value is the length of was encoded into destination > > array excluding '\0'. Thus return value equal to the length of the > > destination array or more means truncation. > > > > This commit fixes improper use of the return value. > > > > Signed-off-by: Tomasz Duszynski > > --- > Good catch. >=20 > Acked-by: Bruce Richardson Since this is a fix, you should add Fixes lines (one per PMD), and CC stabl= e. Thanks! Pablo