From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Stokes, Ian" <ian.stokes@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 1/1] rte_crypto.h: Fix compilation issue with Ofast.
Date: Tue, 17 Oct 2017 11:54:21 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC3530E@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1508238255-30383-1-git-send-email-ian.stokes@intel.com>
Hi Ian,
> -----Original Message-----
> From: Stokes, Ian
> Sent: Tuesday, October 17, 2017 12:04 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stokes, Ian
> <ian.stokes@intel.com>
> Subject: [PATCH v1 1/1] rte_crypto.h: Fix compilation issue with Ofast.
>
> When compiling with an application that includes rte_cryptodev.h with
> Ofast, an error is reported regarding enumeration
> RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function
> __rte_crypto_op_reset().
>
> Fix this by adding case for RTE_OP_TYPE_UNDEFINED.
>
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Since this is a fix, you should add a fixes line with the commit id where the issue was introduced.
This case: Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented")
Also, the title should be: "cryptodev: fix build with Ofast"
Could you send a v2 with these changes?
Thanks,
Pablo
next prev parent reply other threads:[~2017-10-17 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 11:04 Ian Stokes
2017-10-17 11:54 ` De Lara Guarch, Pablo [this message]
2017-10-17 12:50 ` Stokes, Ian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC3530E@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).