From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 314841B5DD
 for <dev@dpdk.org>; Mon, 23 Oct 2017 12:06:49 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga105.jf.intel.com with ESMTP; 23 Oct 2017 03:06:49 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,422,1503385200"; d="scan'208";a="141193785"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by orsmga004.jf.intel.com with ESMTP; 23 Oct 2017 03:06:47 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by
 IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002;
 Mon, 23 Oct 2017 11:06:47 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "jblunck@infradead.org" <jblunck@infradead.org>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
 "yliu@fridaylinux.org" <yliu@fridaylinux.org>, "maxime.coquelin@redhat.com"
 <maxime.coquelin@redhat.com>, "mtetsuyah@gmail.com" <mtetsuyah@gmail.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>
Thread-Topic: [PATCH v7 1/4] cryptodev: remove crypto vdev init API
Thread-Index: AQHTRBl+5vRxVuzKZEa5pMg2lxwCIKLxRG7A
Date: Mon, 23 Oct 2017 10:06:46 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC39834@IRSMSX108.ger.corp.intel.com>
References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com>
 <1507895521-48299-1-git-send-email-jianfeng.tan@intel.com>
 <1507895521-48299-2-git-send-email-jianfeng.tan@intel.com>
In-Reply-To: <1507895521-48299-2-git-send-email-jianfeng.tan@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjJlMDk2YWUtMWVlYy00NWVjLWEyMTMtNGEzYjQ3MDM5YWQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImM1YnpLa3lTZGc0aUdYUThmQUt0OG9iU3VWSjJJWU5nZHdiOHdqQ1g4TDA9In0=
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v7 1/4] cryptodev: remove crypto vdev init API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Oct 2017 10:06:50 -0000

Hi Jianfeng,

> -----Original Message-----
> From: Tan, Jianfeng
> Sent: Friday, October 13, 2017 12:52 PM
> To: dev@dpdk.org
> Cc: jblunck@infradead.org; Richardson, Bruce
> <bruce.richardson@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; thomas@monjalon.net;
> yliu@fridaylinux.org; maxime.coquelin@redhat.com;
> mtetsuyah@gmail.com; Yigit, Ferruh <ferruh.yigit@intel.com>; Tan,
> Jianfeng <jianfeng.tan@intel.com>
> Subject: [PATCH v7 1/4] cryptodev: remove crypto vdev init API
>=20
> Remove rte_cryptodev_create_vdev() for duplication.
>=20
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

...

> --- a/lib/librte_cryptodev/Makefile
> +++ b/lib/librte_cryptodev/Makefile
> @@ -34,7 +34,7 @@ include $(RTE_SDK)/mk/rte.vars.mk  LIB =3D
> librte_cryptodev.a
>=20
>  # library version
> -LIBABIVER :=3D 3
> +LIBABIVER :=3D 4

Sorry for the late review.
Since you are bumping the ABI version, you should also change it in
"Share Library Versions", in release_17_11.rst.

Thanks,
Pablo